Bug 424846 - Add preference for soft-wrap/scrolling in commit message text fields
Summary: Add preference for soft-wrap/scrolling in commit message text fields
Status: REOPENED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2014-01-03 09:23 EST by Markus Keller CLA
Modified: 2015-08-12 19:07 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2014-01-03 09:23:12 EST
org.eclipse.egit.ui_3.3.0.201312271828

Soft-wrap is broken in the Commit Message field in the Git Staging view and in the Commit dialog. I now get a horizontal scroll bar instead.

The opposite of hard-wrapping is usually not single-line, but soft-wrapping. This still works fine in the History view.
Comment 1 Matthias Sohn CLA 2014-01-07 02:20:42 EST
This was changed by intention, see https://git.eclipse.org/r/#/c/20089/
Comment 2 Markus Keller CLA 2014-01-07 07:10:55 EST
> most viewers don't soft-wrap the commit message

That's a strange motivation for breaking a feature that worked perfectly before. Why can't EGit be better than other viewers? And command-line users can just as well enable soft-wrap in their pager, e.g. by setting core.pager to "less -+S".

I don't think no-wrap is often wanted (and that you didn't break the History view seems to confirm this).

Reopening as an enhancement request to support soft-wrap (again).
Comment 3 Robin Stocker CLA 2014-01-07 10:45:10 EST
It was requested here:

http://dev.eclipse.org/mhonarc/lists/egit-dev/msg03372.html

It looks like we need to add another preference for soft wrap in addition to the hard wrap preference.

(By the way, the common practice in Git is to hard wrap commit messages.)
Comment 4 Konstantin Komissarchik CLA 2014-01-07 12:20:38 EST
The common convention for Git comments is to hard wrap free-flowing text and let stuff that shouldn't wrap (stack traces, code samples, etc.) to go beyond the margin. There is a lot of in-depth discussion on various forums as to why that's the convention, but suffice it to say that it is the convention and previous EGit behavior was making it very difficult to follow it.

A switch to turn on soft-wrap for those users who desire such behavior seems reasonable, but EGit should be configured to make it possible to follow the established convention out of the box.
Comment 5 Konstantin Komissarchik CLA 2014-01-07 12:23:27 EST
Do we need a separate bug to do the same to the history view?
Comment 6 Matthias Sohn CLA 2014-01-08 03:14:37 EST
(In reply to Robin Stocker from comment #3)
> It looks like we need to add another preference for soft wrap in addition to
> the hard wrap preference.

+1