Description Markus Keller 2013-12-17 14:05:04 EST

When testing the anonymous -> lambda conversion cleanups on jdt.ui, I saw cases where comments were lost in the process.

We could try to preserve
- Javadoc on the method
- if we create a lambda without a block: comments inside the method body before/after the first/last statement

The comments could be inserted on separate lines just before/after the enclosing statement of the lambda expression.

We should not preserve block comments on the method, since these are often boilerplate /* (non-Javadoc) ... */

Examples:

- TableTextCellEditor.java:

text.addFocusListener(new FocusAdapter() {
    @Override
    public void focusLost(FocusEvent e) {
        e.display.asyncExec(new Runnable() {
            @Override
            public void run() {
                // without the asyncExec, focus has not had a chance to go to the content assist proposals
                TableTextCellEditor.this.focusLost();
            }
        });
    }
});

- IntroduceFactoryRefactoring.java:

	Arrays.sort(hits, new Comparator<SearchMatch>() {
		/**
		 * Sort by descending offset, such that nested constructor calls are processed first.
		 * This is necessary, since they can only be moved into the factory method invocation
		 * after they have been rewritten.
		 */
		@Override
		public int compare(SearchMatch m1, SearchMatch m2) {
			return m2.getOffset() - m1.getOffset();
		}
	});