Bug 424111 - [patch] OpenLogDialog readFile does not close BufferedReader
Summary: [patch] OpenLogDialog readFile does not close BufferedReader
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M5   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2013-12-16 06:24 EST by Lars Vogel CLA
Modified: 2013-12-16 10:21 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2013-12-16 06:24:32 EST 
OpenLogDialog readFile does not close BufferedReader, I upload a Gerrit review in a few minutes for the fix.
Comment 1 Lars Vogel CLA 2013-12-16 06:28:52 EST 
https://git.eclipse.org/r/#/c/19850/
Comment 2 Dani Megert CLA 2013-12-16 09:45:35 EST 
I don't see how an unclosed reader can make it harder to contribute to Eclipse ;-).

Submitted with http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=cec2db4b940a71615083c1ce7a8f009a68ca4c04
Comment 3 Lars Vogel CLA 2013-12-16 09:46:59 EST 
(In reply to Dani Megert from comment #2)
> I don't see how an unclosed reader can make it harder to contribute to
> Eclipse ;-).

True.