Bug 423222 - Vi Keybindings - 'gg' should jump to top of document
Summary: Vi Keybindings - 'gg' should jump to top of document
Status: NEW
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Editor (show other bugs)
Version: 4.0   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2013-12-04 14:32 EST by Stephen Jahns CLA
Modified: 2015-10-10 16:54 EDT (History)
4 users (show)

See Also:
s.t.jahns: review? (ken_walker)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Jahns CLA 2013-12-04 14:32:00 EST 

    


    


      



        
          Comment 1
        

        
          Stephen Jahns CLA

        

        
        

        
          2013-12-04 14:42:16 EST
        

      






Implmentation here - https://github.com/stjahns/orion.client/commit/ed9e9e28369924c4713cd4d13a108a60ebbe4f57
Commit also includes fixes for 423223 and 423221 which also depended on the same 'PrefixMode' that was added to vi.js

    


    


      



        
          Comment 2
        

        
          Ken Walker CLA

        

        
        

        
          2013-12-04 21:37:28 EST
        

      






regarding the prefix options.  Take this one "gg" for example.

If you us the following sequence in cmd line vi

"g" (esc) - it cancels it
"gg" - goes to top of file

In your implementation

"g" (esc)
"g" - goes to top of file

I think that esc should

    


    


      



        
          Comment 3
        

        
          Ken Walker CLA

        

        
        

        
          2013-12-04 21:38:19 EST
        

      






oops accidental save.  I think that hitting "esc" should cancel the prefix mode?

    


    


      



        
          Comment 4
        

        
          Stephen Jahns CLA

        

        
        

        
          2013-12-11 18:00:33 EST
        

      






Yep!

    


    


      



        
          Comment 5
        

        
          Stephen Jahns CLA

        

        
        

        
          2013-12-11 18:01:12 EST
        

      






Fix in this subsequent commit: https://github.com/stjahns/orion.client/commit/3d6e8817f67f993b52069d18e715d911738300e3

    


    


      



        
          Comment 6
        

        
          Tony Lee CLA

        

        
        

        
          2015-10-10 16:54:17 EDT
        

      






working on it.