Bug 423033 - Crash during loc_free of peer server
Summary: Crash during loc_free of peer server
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: 1.1   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 1.2   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-03 08:49 EST by Christophe Augier CLA
Modified: 2014-02-25 05:50 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Augier CLA 2013-12-03 08:49:37 EST 
The agent may crash if no transport name is provided in the URL. When the peer server structure gets freed the TransportName property can't be freed.

The line causing the crash is line 309 in channel.c:

        peer_server_addprop(ps, "TransportName", transportname);

The second and third argument should be duplicated using loc_strdup() for instance instead of using the literal strings.
Comment 1 Eugene Tarassov CLA 2013-12-03 13:12:56 EST 
Fixed.
Comment 2 Christophe Augier CLA 2013-12-05 04:28:08 EST 
Thanks Eugene!