Community
Participate
Working Groups
I tried some more scenarios with the new blame navigation using the new "Show annotations" links. When opening annotations for the HEAD version of a file and hovering over a hunk which isn't matching the last change of the file we look at, e.g. a hunk which was changed in the second last change on this file, there is no way to directly open the annotations for the second last change of this file since "Show annotations" link is only available on the predecessor of second last change which is the third last change. So it seems we should show one more "Show annotations" link on the commit shown in the hover if the hunk's commit doesn't match the last version of the file we look at.
Created attachment 237630 [details] sample repository
Example using the sample repository: - unzip and import the sample repository and project - open class A - Team > Show Annotations - hover over second hunk (method a()) - BlameInfo shows commit 1927bf8, fine - I can open the commit and show it in history view - I can show annotations for its predecessor 593c38e in a new editor window - but I cannot directly show 1927bf8 with annotations in a new editor window
Thanks for the example. (In reply to Matthias Sohn from comment #2) > - but I cannot directly show 1927bf8 with annotations in a new editor window You can select the file in the history view and select "Show Annotations". The thing is, I'm not sure this is really that important to make it accessible from the hover. The opened editor with annotations for 1927bf8 has the same blame information for that hunk as it did in the original editor, right? But I guess the use case could be "hey, I want to see the contents of the file at that commit because I want to know how the rest of it looked like"? Ok, so we will add another link on the title line? Like this?: Commit 1927bf8 (open commit) (show in history) (show annotations) And it should only be shown when the annotations are not already for that commit. Do you plan to do that change? :)
(In reply to Robin Stocker from comment #3) > Thanks for the example. > > (In reply to Matthias Sohn from comment #2) > > - but I cannot directly show 1927bf8 with annotations in a new editor window > > You can select the file in the history view and select "Show Annotations". > > The thing is, I'm not sure this is really that important to make it > accessible from the hover. The opened editor with annotations for 1927bf8 > has the same blame information for that hunk as it did in the original > editor, right? > > But I guess the use case could be "hey, I want to see the contents of the > file at that commit because I want to know how the rest of it looked like"? exactly, this was my reasoning > Ok, so we will add another link on the title line? Like this?: > > Commit 1927bf8 (open commit) (show in history) (show annotations) > > And it should only be shown when the annotations are not already for that > commit. Do you plan to do that change? :) I'll try to find time :-)
