Description Tobias Bertelsen 2013-11-21 10:35:26 EST

==Setup==
We are building a p2-site with pde-build and using it to install/update our Eclipse-RCP based products. On mac we are using the bundled mode, by having the foldername end with '.app'. This structures the product as a proper mac-application, with everything in one folder that can be drag/dropped into the application directory.


==Problem==
The problem is that inside the specified folder, another .app folder is generated, so the structure looks like this.

MyProduct.app
  ..
  Contents/
    ...
  Plugins/
    ...
  MyProduct.app/
    ...
    Content/
      ...


That extra folder is just garbage. It doesn't even has its executable bit set. The structure should look like:

MyProduct.app
  ..
  Contents/
    ...
  Plugins/
    ...

==Reason==
In the generated context.xml file in the update site, there is an iu responsible for extracting the binary files. It is called something like MyProduct.product_root.cocoa.macosx.x86_64-bundled
It contains two groups of install-instructions

  <instruction key='install'>
    unzip(source:@artifact, target:${installFolder});
  </instruction>

  <instruction key='install'>
    unzip(source:@artifact, target:${installFolder}, path:MyProduct.app); chmod(targetDir:${installFolder}/Contents/MacOS/, targetFile:MyProduct, permissions:755);
  </instruction>

The first one is a bug and should not be there. It is the unzip instruction for the unbundled IU.