Bug 421097 - Open redirect
Summary: Open redirect
Status: CLOSED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Website (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Christopher Guindon CLA
QA Contact:
URL: https://dev.eclipse.org/site_login/?t...
Whiteboard:
Keywords: security
Depends on:
Blocks:
 
Reported: 2013-11-05 12:32 EST by Gurjant Singh CLA
Modified: 2015-05-25 16:06 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gurjant Singh CLA 2013-11-05 12:32:11 EST
Hello sir..
I find the open redirect in your domain
here is poc:-
https://dev.eclipse.org/site_login/?takemeback=http://google.com

just open the link and click on continue..
and you directly redirect to google.com
Comment 1 Wayne Beaton CLA 2013-11-05 12:35:46 EST
Is this a real vulnerability? Can it be used to hijack our site, steal cookies, or otherwise compromise user data or the site itself?
Comment 2 Gurjant Singh CLA 2013-11-05 12:40:12 EST
i am not sure about that.. but i get your user to .. my own harmful page.. 
even your not click on my site link here... user trust your domain.. 
as he/she trust your domain click on continue so i effect user..
it also bad image of your site in user view
Comment 3 Denis Roy CLA 2013-11-05 13:00:27 EST
Correct.  There's no issue for us specifically, but our site is trusted, so someone could take advantage of the open redirect to redirect to an evil site that looks just like ours.

I'll fix this, I'm already in the code.
Comment 4 Gurjant Singh CLA 2013-11-05 13:01:38 EST
so no hall of fame or no reward? nothing.. ?
Comment 5 Gurjant Singh CLA 2013-11-05 13:03:58 EST
hey,,
it also cause xss. 
by this request
https://dev.eclipse.org/site_login/?takemeback=http://javascript:alert(1);
as this is some sort of store xss. when your click on continue javascript script execute in same tab.. that causes the xss.
this is harmful..
thanks
Comment 6 Denis Roy CLA 2013-11-05 13:07:31 EST
We don't have a hall of fame, unfortunately. We promise to love you long time, though.
Comment 7 Gurjant Singh CLA 2013-11-05 13:08:41 EST
just send me simple certificate form your side.. on which my name and your sign..
that help me many ways..
i wanna show it to my boss
Comment 8 Denis Roy CLA 2013-11-05 13:10:38 EST
>  on which my name and your sign..

Should I write your name "ScRiptalert1ScRipt img srcasd onerrorprompt1" or simply Mr. onerrorprompt1 ?
Comment 9 Gurjant Singh CLA 2013-11-05 13:11:30 EST
hey my name is 
Gurjant Singh Sadhra(hackerdesk)
Comment 10 Gurjant Singh CLA 2013-11-05 13:14:00 EST
and can you provide..me 2 certificates... for my partner we work hard to find issue,, his name is:-
Mayank Kappor(hackerdesk)
Comment 11 Denis Roy CLA 2013-11-05 13:15:23 EST
Unfortunately, we don't have a hall of fame, and we don't provide certificates.  However, once this bug is fixed, it will be visible to the entire world.

Thanks for providing feedback.
Comment 12 Gurjant Singh CLA 2013-11-05 13:19:21 EST
please make a simple page.. and list all security researchers.. 
it is request..
Comment 13 Denis Roy CLA 2013-11-05 13:23:27 EST
Proposed fix is to scope only Foundation domains.

https://git.eclipse.org/r/#/c/18095/
Comment 14 Denis Roy CLA 2013-11-05 13:25:12 EST
> please make a simple page.. and list all security researchers.. 
> it is request..

And a fair one.  I've opened bug 421105 for this.
Comment 15 Gurjant Singh CLA 2013-11-05 13:29:48 EST
i am not able to understand last 2 messages// :/
Comment 16 Denis Roy CLA 2013-11-05 15:18:36 EST
This was pushed in.  Thanks for the report.
Comment 17 Denis Roy CLA 2013-11-28 09:53:53 EST
Removing the Security group since this is fixed.
Comment 18 Gurjant Singh CLA 2013-11-28 09:54:58 EST
what and you tell me to start hall of fame when you start that?
Comment 19 Gurjant Singh CLA 2013-11-28 10:12:30 EST
and please remove useless post on this page. and make it simple and clean thanks
Comment 20 Denis Roy CLA 2014-06-04 16:47:17 EDT
(In reply to Denis Roy from comment #13)
> Proposed fix is to scope only Foundation domains.
> 
> https://git.eclipse.org/r/#/c/18095/

I think the regexps would still allow for something like:

http://www.eclipse.org.someevilsite.com/nasty.php
Comment 21 Christopher Guindon CLA 2015-01-14 13:50:58 EST
(In reply to Denis Roy from comment #20)
> (In reply to Denis Roy from comment #13)
> > Proposed fix is to scope only Foundation domains.
> > 
> > https://git.eclipse.org/r/#/c/18095/
> 
> I think the regexps would still allow for something like:
> 
> http://www.eclipse.org.someevilsite.com/nasty.php

This currently also allows this:

https://www.hack-eclipse.org
Comment 22 Christopher Guindon CLA 2015-01-14 15:29:54 EST
I committed a solution for the new site_login:
https://git.eclipse.org/c/websites/dev.eclipse.org.git/commit/?id=4b570f9a0c1e4d5e737acdc4a60c975c3b201b7e

I wrote a small test page to prove this concept:
https://dev.eclipse.org/site_login_new/tests/validate.takemeback.php
Comment 23 Christopher Guindon CLA 2015-05-25 16:06:01 EDT
Done. Closing this bug.