Bug 419906 - [JUnit] JUnit View fails to refresh decorations
Summary: [JUnit] JUnit View fails to refresh decorations
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 416354 420702
Blocks:
  Show dependency tree
 
Reported: 2013-10-19 09:50 EDT by Ed Willink CLA
Modified: 2013-10-30 04:25 EDT (History)
2 users (show)

See Also:


Attachments
Screenshot of missing test suite decorations (111.79 KB, image/png)
2013-10-27 10:10 EDT, Ed Willink CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2013-10-19 09:50:11 EDT
M2: (This is probably a platform bug but ...)

Normally the JUnit view updates each test with a pass/fail decoration as the tests progress.

With M2 I am quite frequently seeing that some of the icon decoration updates have got lost. For instance I can open a test suite that reports that it and its predecessors are still to do, but discover that the tests have actually run (the per-test decorations are correct).

The "Runs" counts seem to update correctly, so the problem seems to be just one of decorator refresh.
Comment 1 Martin Mathew CLA 2013-10-21 02:09:12 EDT
Can you provide a screenshot next time you encounter the issue? I used Eclipse Version: 4.4.0 Build id: I20131015-0800, executed AllRefactoringTests multiple times but couldn't reproduce the issue. Is it always reproducible at your end, if so provide us the details or attach a sample testsuite so that it can be reproduced at our end.
Comment 2 Ed Willink CLA 2013-10-21 02:44:39 EDT
Sorry. It's thoroughly unreproducible. Hence....

(In reply to Ed Willink from comment #0)
> M2: (This is probably a platform bug but ...)

The platform has so many unpredictable activate/refresh issues that it's difficult to report anything useful.

[The missing decorations appear after a suitable refresh, so it's definitely a display bug.]
Comment 3 Dani Megert CLA 2013-10-21 08:32:49 EDT
Ed, can you give a bit more details:
- you mean the decorations of the elements, not the view icon, right?
- is the JUnit view open in your workbench window as view or as fast view, or in 
  another window, or detached?
- by "open a test suite", you mean expand the node in the view?
Comment 4 Ed Willink CLA 2013-10-21 08:42:46 EDT
(In reply to Dani Megert from comment #3)
> Ed, can you give a bit more details:
> - you mean the decorations of the elements, not the view icon, right?
Yes (the 8x8 green tick icon overlaying the node icon at bottom left)
> - is the JUnit view open in your workbench window as view or as fast view,
> or in 
>   another window, or detached?
As a view in multiple perspectives. (In the horizontal Search/Error LOg/Tasks/... area.)
> - by "open a test suite", you mean expand the node in the view?
Yes expand to show the results of each test.
Comment 5 Dani Megert CLA 2013-10-21 08:47:59 EDT
(In reply to Ed Willink from comment #4)
> (In reply to Dani Megert from comment #3)
> > Ed, can you give a bit more details:
> > - you mean the decorations of the elements, not the view icon, right?
> Yes (the 8x8 green tick icon overlaying the node icon at bottom left)
> > - is the JUnit view open in your workbench window as view or as fast view,
> > or in 
> >   another window, or detached?
> As a view in multiple perspectives. (In the horizontal Search/Error
> LOg/Tasks/... area.)
> > - by "open a test suite", you mean expand the node in the view?
> Yes expand to show the results of each test.

And one additional question: could it be that you see this when rerunning a test/tests?
Comment 6 Ed Willink CLA 2013-10-21 09:06:44 EDT
(In reply to Dani Megert from comment #5)
> And one additional question: could it be that you see this when rerunning a
> test/tests?

Certainly possible, but probably both. The typical scenario is that my tests go a bit slow after about 75% (garbage collection issues) and decorations stop updating. It is only when I probe to see why no progrees is being made that I started to notice it was a decoartion issue.  I can open an undecorated test suite at say 90%, and see that the individual tests are decorated; the parent also acquires a decoration because of the refresh, but its predecessors may remain undecorated.
Comment 7 Ed Willink CLA 2013-10-27 10:10:57 EDT
Created attachment 236936 [details]
Screenshot of missing test suite decorations

Test was first launch after starting Eclipse.
Comment 8 Dani Megert CLA 2013-10-29 14:10:37 EDT
I can easily reproduce when I run a test suite directly after starting Eclipse, when it's still busy decorating other images (also in other views).

I'm pretty sure that the fix for bug 416354 surfaced this issue in the decoration manager. I've reverted that change so that I can verify my theory in the next build.
Comment 9 Dani Megert CLA 2013-10-30 04:00:40 EDT
Verified in I20131029-2000 that this fixes the problem.