Bug 419889 - Remove duplicate project facet version for JAX-RS 2.0
Summary: Remove duplicate project facet version for JAX-RS 2.0
Status: NEW
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 3.5.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.5.1 P   Edit
Assignee: Keith Chong CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on: 419540
Blocks: 419541
  Show dependency tree
 
Reported: 2013-10-18 15:51 EDT by Keith Chong CLA
Modified: 2014-01-15 11:27 EST (History)
6 users (show)

See Also:
keith.chong.ca: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
keith.chong.ca: pmc_approved? (naci.dai)
keith.chong.ca: pmc_approved? (neil.hauge)
keith.chong.ca: pmc_approved? (cbridgha)
keith.chong.ca: pmc_approved? (kaloyan)

Attachments
Apply to org.eclipse.jst.ws.jaxrs.core (856 bytes, patch)
2013-10-18 16:26 EDT, Keith Chong CLA 		no flags Details | Diff
Apply to org.eclipse.jst.ws.jaxrs.core R3_5_1_patches (1.10 KB, patch)
2013-10-22 15:13 EDT, Keith Chong CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Chong CLA 2013-10-18 15:51:03 EDT 
+++ This bug was initially created as a clone of Bug #419540 +++

This appears to be unneeded since it is already defined.

Opened for 3.5.1 patches
Comment 1 Keith Chong CLA 2013-10-18 16:26:33 EDT 
Created attachment 236676 [details]
Apply to org.eclipse.jst.ws.jaxrs.core

Version not updated.
Comment 2 Keith Chong CLA 2013-10-22 15:13:00 EDT 
Created attachment 236785 [details]
Apply to org.eclipse.jst.ws.jaxrs.core R3_5_1_patches

Updated patch.
Comment 3 Keith Chong CLA 2013-10-23 17:06:08 EDT 
Here is the exception:

org.eclipse.core.runtime.AssertionFailedException: assertion failed: 
	at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110)
	at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96)
	at org.eclipse.wst.common.project.facet.ui.internal.util.ReadOnlyComboBoxCellEditor.doSetValue(ReadOnlyComboBoxCellEditor.java:264)
	at org.eclipse.jface.viewers.CellEditor.setValue(CellEditor.java:857)
	at org.eclipse.wst.common.project.facet.ui.internal.FacetsSelectionPanel$FacetVersionColumnEditingSupport.getCellEditor(FacetsSelectionPanel.java:1431)
	at org.eclipse.jface.viewers.ColumnViewerEditor.activateCellEditor(ColumnViewerEditor.java:166)
	at org.eclipse.jface.viewers.ColumnViewerEditor.handleEditorActivationEvent(ColumnViewerEditor.java:445)
	at org.eclipse.jface.viewers.ColumnViewer.triggerEditorActivationEvent(ColumnViewer.java:698)
	at org.eclipse.jface.viewers.ColumnViewer.editElement(ColumnViewer.java:445)
	at org.eclipse.jface.viewers.TreeViewer.editElement(TreeViewer.java:1163)
	at org.eclipse.wst.common.project.facet.ui.internal.FacetsSelectionPanel.handleMouseDownEventHelper(FacetsSelectionPanel.java:838)
	at org.eclipse.wst.common.project.facet.ui.internal.FacetsSelectionPanel.handleMouseDownEvent(FacetsSelectionPanel.java:823)
	at org.eclipse.wst.common.project.facet.ui.internal.FacetsSelectionPanel.access$12(FacetsSelectionPanel.java:821)
	at org.eclipse.wst.common.project.facet.ui.internal.FacetsSelectionPanel$8.handleEvent(FacetsSelectionPanel.java:333)

This may prevent the user from changing the version of the JAX-RS facet.

Because of this, in the project facet page, the JAX-RS facet version cannot be changed.
Comment 4 Keith Chong CLA 2013-10-23 17:22:16 EDT 
PMC approval requested to make this patch public.

Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

Requested by adopter.   This problem may prevent the JAX-RS facet version from being changed from the Project Facets page.

Is there a work-around? If so, why do you believe the work-around is insufficient? 

Yes, change the .settings of the web project.  But this isn't really acceptable.

How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Manual testing has been done.

Give a brief technical overview. Who has reviewed this fix? 

The JAX-RS 2.0 facet version is duplicated in the plugin.xml and references a java version that doesn't exist.  This was inadvertantly added and should be removed.

What is the risk associated with this fix? 

Low risk.
Comment 5 Raghunathan Srinivasan CLA 2013-10-31 14:34:20 EDT 
Must fix.