Community
Participate
Working Groups
1. Try to create a file named "a%b.js" 2. You get an internal server error. This is because various places in the server attempt to URL-decode input from the client when they should not. Some helper methods (eg. fileUtil.safeFilePath) implicitly perform URL decoding of arguments, which is bad. Here is how POSTs should be handled: -The server should attempt to decode the Slug header -The server should *not* attempt to decode the Name field in the request body (if provided) -A valid Slug is preferred over Name, if both are provided (this align us with the Java server). I tried to fix this in bug 419740 but the problem is pervasive and too risky for this stage of a release.
This open bug report had a target milestone in the past. The target milestone has been removed. Please target for a date in the future or leave the target blank if it is not known.
Released changes to fix this problem. Everything seems to work when running a local server, but file names with ? and # still fail behind the orion.eclipse.org proxy.
1. Create a folder a%b/. 2. Create the file tmp.txt inside the a%b/ folder. 3. Rename the file to tmp2.txt. 4. The rename will fail with an error. File not found:/file/a%25b/tmp.txt
orion.eclipse.org Works fine on OrionHub. 1. Create an untracked file named 'a%b.txt' in a folder that's under Git version control. 2. Open the 'Git' page. 3. Try to expand the untracked file's node to look at its diff. You will stay in the 'fetching...' state forever. There's a 404 in the console presumably because the % was not URL encoded...? Failed to load resource: the server responded with a status of 404 (Not Found) https://orion.eclipse.org/gitapi/diff/Default/file/org.eclipse.orion.client/a%b.txt?parts=diff&ignoreWS=false
(In reply to Remy Suen from comment #4) > orion.eclipse.org > > Works fine on OrionHub. > > 1. Create an untracked file named 'a%b.txt' in a folder that's under Git > version control. > 2. Open the 'Git' page. > 3. Try to expand the untracked file's node to look at its diff. You will > stay in the 'fetching...' state forever. > > There's a 404 in the console presumably because the % was not URL encoded...? > > Failed to load resource: the server responded with a status of 404 (Not > Found) > https://orion.eclipse.org/gitapi/diff/Default/file/org.eclipse.orion.client/ > a%b.txt?parts=diff&ignoreWS=false I have identified the cause for this scenario and have opened bug 512061 for this problem.
I can confirm that Remy's case in comment 3 still happens.
(In reply to Steve Northover from comment #6) > I can confirm that Remy's case in comment 3 still happens. Confirmed this still happens in Orion 15.0
Fixed Remy's case with: https://github.com/eclipse/orion.client/commit/9d166938bc1cf5a5b9c837dad493a7725130cb74
