Bug 4193 - eliminate JavaUIException (1GJW6KL)
Summary: eliminate JavaUIException (1GJW6KL)
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Adam Kiezun CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 23:07 EDT by Erich Gamma CLA
Modified: 2002-02-05 07:29 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erich Gamma CLA 2001-10-10 23:07:36 EDT
EG (11.09.2001 16:02:57)
	JavaUIException has to eliminated.
	it is currently used as follows:

		if (!status.isOK()) {
			Throwable t= new JavaUIException(status);
			ExceptionHandler.handle(t, activeShell, ReorgMessages.getString("moveAction.error.title"), ReorgMessages.getString("moveAction.error.message")); //$NON-NLS-1$ //$NON-NLS-2$
		} else {

	either ExceptionHandler can take an IStatus directly or the error message is inlined.
NOTES:
Comment 1 Dirk Baeumer CLA 2002-01-29 10:40:53 EST
I think we should keep the JavaUIException since it gives use the possibility 
to distinguish between Core, JavaCore and JavaUI exceptions (we shouldn't 
through an core exception if it is aUI thing).

Regarding the use of the exception to pass a status to the exception handler. 
In this cases the client should use the ErrorDialog directly (see 
ErrorDialog.openError(shell, title, message, status));

Moving to Adam to clean up wrong uses of JavaUIException.
Comment 2 Erich Gamma CLA 2002-01-29 19:06:40 EST
Keeping it is fine but then we should make the corresponding
status class conform to the platform conventions. It is currently called
JavaUIErrorStatus it should be called JavaUIStatus. It should support to pass 
in a code (see the VCMException as an example). We should also introduce status 
constants in an IJavaUIStatus interface.
Comment 3 Adam Kiezun CLA 2002-02-05 07:29:33 EST
fixed 
(the constants are defined in JavaStatusConstants class)