Bug 418675 - No breakpoint error is reported when source line info cannot be found
Summary: No breakpoint error is reported when source line info cannot be found
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.2   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-04 08:44 EDT by Didier Brachet CLA
Modified: 2014-02-25 05:50 EST (History)
1 user (show)

See Also:


Attachments
gerrit fix (36 bytes, text/plain)
2013-10-08 08:17 EDT, Didier Brachet CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Didier Brachet CLA 2013-10-04 08:44:19 EDT
Build Identifier: 

When using the TCF Eclipse Breakpoint view to set a breakpoint, if one sets a breakpoint on a function name that cannot be resolved, then when looking at status in the breakpoint properties, there is an explicit error message indicating that the breakpoint could not be planted because the identifier is undefined. This gives insight to the user about the root cause of the error.

When setting a breakpoint on a source line number and the source line cannot be found or path mapping is not correctly set (e.g.) then no error is reported in the breakpoint properties status entry, the only message that can be seen is "Not planted". This message provides very limited information on the error and users do not easily understand what's going on. As a user, I would expect to see an error message like this one:

"Error: Unknown source line"

Eugene, let me know if you agree on this and I will start working on a fix in the agent.


Reproducible: Always
Comment 1 Eugene Tarassov CLA 2013-10-04 13:17:09 EDT
I agree, a better error message would help.
Comment 2 Didier Brachet CLA 2013-10-08 08:17:18 EDT
Created attachment 236209 [details]
gerrit fix
Comment 3 Didier Brachet CLA 2013-10-08 08:17:54 EDT
Fix commited
Comment 4 Didier Brachet CLA 2013-10-08 08:18:47 EDT
Patch committed; thanks Eugene.