Bug 417971 - [repoView] Double-clicking on branch or tag in Git Repositories view should ask for confirmation
Summary: [repoView] Double-clicking on branch or tag in Git Repositories view should a...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2013-09-24 18:28 EDT by Adam Lock CLA
Modified: 2013-10-30 17:21 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Lock CLA 2013-09-24 18:28:41 EDT
Double clicking on a tag or branch in Git Repository Explorer checks out what was double clicked on. This can be a very expensive operation and if it was inadvertent it can be a major nuisance. 

I've suffered this a couple of times in a project with 40K+ files and it might take several minutes to switch and another several minutes to switch back complete with any complications from auto build, staging etc.

A double click should pose a confirmation dialog asking the user if they wish to continue to check out the branch. Alternately the double click should open the checkout branch dialog prefilled with the proper values. This would avoid inadvertent checkouts and make the operation explicit.

Failing this, there needs to be a setting which disables checkout on double click, or which modifies it to a less painful action such as show history.
Comment 1 Robin Stocker CLA 2013-09-24 19:02:59 EDT
+1, I think this would make sense on double-click. Checkout via context menu should stay as it currently is.

To implement this, OpenCommand needs to show a MessageDialog with a confirmation in case of a branch or tag. It should not show a confirmation dialog in case checkout already asks a question (checkout of remote-tracking branch), see BranchOperationUI.checkoutWillShowQuestionDialog.
Comment 2 Boris Brodski CLA 2013-10-30 03:10:25 EDT
Contribution from EclipseCon Europe 2013 Hackathon: https://git.eclipse.org/r/#/c/17866/

Thanks, Robin!
Comment 3 Stefan Lay CLA 2013-10-30 14:02:44 EDT
Fixed with e5fa5fd5d9be3082cac2932ab7981aa02357e770