Bug 417876 - better content assist support for node.js
Summary: better content assist support for node.js
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.0 RC1   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2013-09-23 18:48 EDT by Manu Sridharan CLA
Modified: 2013-10-03 21:02 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manu Sridharan CLA 2013-09-23 18:48:52 EDT 
I've implemented better content assist support for node.js in this branch:

https://github.com/msridhar/orion.client/tree/node-modules

Here is the commit:

https://github.com/msridhar/orion.client/commit/c06714456e25de4df148f421384757662322c62f

See the commit comment for further details.  If there are any questions, please let me know.
Comment 1 Mark Macdonald CLA 2013-09-30 11:42:22 EDT 
I pushed the changes -- thanks Manu. However I did find a few issues with the "Buffer"-related globals -- see bug 418356.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=931be5b
Comment 2 Mark Macdonald CLA 2013-09-30 11:44:38 EDT 
Also added the indexFileParsing tests to our build-time test suite:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5033b78