Bug 417045 - Add identifier-type to extension point schemas
Summary: Add identifier-type to extension point schemas
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.4 M2   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2013-09-11 18:29 EDT by Jesse Weinstein CLA
Modified: 2013-09-16 04:39 EDT (History)
2 users (show)

See Also:


Attachments
Add identifier-type to various attributes, and other minor fixes (50.17 KB, patch)
2013-09-11 19:46 EDT, Jesse Weinstein CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Weinstein CLA 2013-09-11 18:29:15 EDT
I'll soon attach a patch adding appropriate instances of identifier-type (and References, where appropriate) to the various extension point schemas (.exsd files) in eclipse.pde.ui .
Comment 1 Jesse Weinstein CLA 2013-09-11 19:46:44 EDT
Created attachment 235410 [details]
Add identifier-type to various attributes, and other minor fixes

Here is the promised patch.
Comment 2 Curtis Windatt CLA 2013-09-12 14:31:42 EDT
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=1cb12e0a9b8856c79e0d5db160b540345db3edd7
Fixed in master

Everything looks good in the patch, no problems in my workspace and I can still use the extension points in a target workspace.  Thanks for the contribution.
Comment 3 Jesse Weinstein CLA 2013-09-12 14:35:02 EDT
Thanks for the prompt merge! Since you responded before the other projects I contributed these changes to, I'll look into doing other similar fixes in PDE first in the future.
Comment 4 Dani Megert CLA 2013-09-13 08:50:13 EDT
This needs further attention: we now get the 5 warnings on our doc bundles:

Description	Resource	Path	Location	Type
Referenced resource 'http://junit-team.github.io/junit/javadoc/latest/' in attribute 'path' cannot be found	plugin.xml	/org.eclipse.jdt.doc.isv	line 51	Plug-in Problem
Referenced resource 'http://hamcrest.org/JavaHamcrest/javadoc/1.3/' in attribute 'path' cannot be found	plugin.xml	/org.eclipse.jdt.doc.isv	line 54	Plug-in Problem
Referenced resource 'reference/api' in attribute 'path' cannot be found	plugin.xml	/org.eclipse.jdt.doc.isv	line 36	Plug-in Problem
Referenced resource 'reference/api' in attribute 'path' cannot be found	plugin.xml	/org.eclipse.platform.doc.isv	line 49	Plug-in Problem
Referenced resource 'reference/api' in attribute 'path' cannot be found	plugin.xml	/org.eclipse.pde.doc.user	line 65	Plug-in Problem



This needs to be fixed for M2.
Comment 5 Curtis Windatt CLA 2013-09-13 10:13:13 EDT
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=46d5dbb464a3b6c1f0378c61e10f8e7f1c69c446

The javadoc path can be a url or a path, it does not necessarily represent an existing project resource.

Also removed the resource type from the samples extension as the project relative path is relative to the created samples project, not the contributing plug-in.  The resource type added to the source extension point is correct.
Comment 6 Dani Megert CLA 2013-09-16 04:39:47 EDT
(In reply to Curtis Windatt from comment #5)
> http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/
> ?id=46d5dbb464a3b6c1f0378c61e10f8e7f1c69c446
> 
> The javadoc path can be a url or a path, it does not necessarily represent
> an existing project resource.
> 
> Also removed the resource type from the samples extension as the project
> relative path is relative to the created samples project, not the
> contributing plug-in.  The resource type added to the source extension point
> is correct.

Verified in I20130915-2000 and master.