Comment 1 Silenio Quarti 2013-09-10 12:34:05 EDT

This commit adds a simple ECMAScript 5 shim to the standalone editor. Only the necessary bits to get it running on IE8.  It also fixes the hit testing problems caused by a bug in TextRange.getClientRects() which returned an empty array if the start offset is zero.  There are also changes to fix content assist and tooltips (i.e. addEventListener).

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ee654049bb9ec9c3cbcbdc0d35df79c7d9dcdf7c

Comment 2 Angelo ZERR 2013-09-13 03:05:22 EDT

Silenio,

There is a bug, when you open the completion and try to close it when you click with mouse outside the popup completion.

Line 17172 the code is  : 

------------------
onMouseDown: function(event) {
	if (event.event.target.parentElement !== self.parentNode) {
		self.contentAssist.deactivate();
	}
...
------------------

and it should be :

------------------
onMouseDown: function(event) {
	var target = event.event.target || event.event.srcElement;
	if (target.parentElement !== self.parentNode) {
		self.contentAssist.deactivate();
	}
...
------------------

Comment 3 Silenio Quarti 2013-09-13 10:35:01 EDT

Thanks!

Fixed

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=1943f2d0b5b4e0889a88a7682b93be94af266fd9

Comment 4 Angelo ZERR 2013-09-19 04:19:50 EDT

(In reply to Silenio Quarti from comment #3)
> Thanks!
> 
> Fixed
> 
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/
> ?id=1943f2d0b5b4e0889a88a7682b93be94af266fd9

Hi Silenio,

Since I201309162230, the completion doesn't work with IE8. (201309152230 works great). (no javascript errors).

Manu thank's for your help.

Comment 5 Silenio Quarti 2013-09-19 12:40:00 EDT

(In reply to Angelo ZERR from comment #4)
> Since I201309162230, the completion doesn't work with IE8. (201309152230
> works great). (no javascript errors).
> 
> Manu thank's for your help.

We started calling Array.isArray in content assist and we did not have a shim for it. Fixed

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f9de99d820b5749a6f347bbb896240ce262718af