Community
Participate
Working Groups
I'm always puzzled when I look at all the possible choices of the Fetch dialog. Especially the meaning of "Update FETCH_HEAD only" is a little unclear, given that all choices are labeled as "Action to perform *after* fetch", so that I'd expect the FETCH_HEAD to be updated already at that time. It probably should say "None". But I may be wrong and this is not what I'm going to ask for ;-) Personally I'm very used to work with the staging view. It always shows a nice overview of all changed files and my text editors can nicely display the quick diff annotations that make reviewing so easy. Would it be possible to add a choice to the Fetch dialog, in analogy to Gerrit's web UI, that applies the changeset as a patch? Like for example this: git fetch ssh://estepper@git.eclipse.org:29418/cdo/cdo refs/changes/86/16086/2 && git format-patch -1 --stdout FETCH_HEAD | git apply
Thinkning about it once more, I get the impression that local branch or tag creation is kind of orthogonal and could be useful for the patch application, too. I mean, at some point I need to commit/push the changes and all too often it happens that I accidentally commit to, e.g., master.
This is an interesting idea. I'm moving it to EGit since that's where the dialog comes from. Personally I probably wouldn't use this since it would require committing my local changes first - in fact the option should come with a warning if you have uncommitted changes. I think I would rather have the option to open the workspace version of a file from the review.
Am I understanding that right that you want the fetched change to be only applied to the index? There are a few open questions/problems with that: - This would lose the commit message - What if there was more than one change fetched (change dependency)? Apply them squashed? Or do you want an option to `git am` the change(s) to the current branch? By the way, regarding quick diff, are you aware that you can set the quick diff baseline to a commit in the history view?
I don't know if the commit message matters in this use case, but I suppose the commit dialog and staging view could be auto-populated with the message from the fetched commit.
