Bug 416362 - Made the ARM build more configurable
Summary: Made the ARM build more configurable
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 1.2   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-02 09:35 EDT by Renan Le Padellec CLA
Modified: 2014-05-27 22:40 EDT (History)
1 user (show)

See Also:

Attachments
Patch proposal (2.48 KB, text/plain)
2013-09-02 09:38 EDT, Renan Le Padellec CLA 		no flags Details
Patch proposal (2.59 KB, patch)
2013-09-06 10:02 EDT, Renan Le Padellec CLA 		mober.at+eclipse: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Renan Le Padellec CLA 2013-09-02 09:35:03 EDT 
With the current implementation, it's impossible to build an ARM agent without the following features:

 - ENABLE_add_cpudefs_disassembler
 - ENABLE_external_stepping_mode
 - ENABLE_HardwareBreakpoints
Comment 1 Renan Le Padellec CLA 2013-09-02 09:38:14 EDT 
Created attachment 235076 [details]
Patch proposal
Comment 2 Eugene Tarassov CLA 2013-09-03 14:13:13 EDT 
The patch looks good, but I cannot commit it: Eclipse now requires contributors to sign Contributor License Agreement and add "Signed-off-by" entry in patches.

Please see http://wiki.eclipse.org/CLA
Comment 3 Renan Le Padellec CLA 2013-09-04 04:03:12 EDT 
(In reply to Eugene Tarassov from comment #2)
> The patch looks good, but I cannot commit it: Eclipse now requires
> contributors to sign Contributor License Agreement and add "Signed-off-by"
> entry in patches.
> 
> Please see http://wiki.eclipse.org/CLA

Ok, I'll sign the CLA.

Thanks
Comment 4 Renan Le Padellec CLA 2013-09-06 10:02:41 EDT 
Created attachment 235243 [details]
Patch proposal
Comment 5 Eugene Tarassov CLA 2013-09-10 14:45:06 EDT 
The server still does not accept the patch:

remote: Reviewing commit: commit 621c78dfca2ede978461f71af28e52ff34b59dd5 1378834938 ----sp
remote: Authored by: renan <renan.le-padellec@windriver.com>
remote:
remote: error: The author does not have a Gerrit account.
remote: All authors must either be a commiter on the project, or have a current CLA on file.

I think it is a glitch, CLA appears valid and should be sufficient to accept the patch, so I committed it without headers.

Fixed.
Thanks!
Comment 6 Martin Oberhuber CLA 2014-05-27 22:40:06 EDT 
Comment on attachment 235243 [details]
Patch proposal

Marking patch iplog+ since the commit appears with Eugene as the Author:

https://git.eclipse.org/c/tcf/org.eclipse.tcf.agent.git/commit/agent/machine/arm/tcf/cpudefs-mdep.c?id=8819da34fc450e7366bb1ad0bcf8a7a8f4ed5fa2