Bug 415958 - RepositoryAction checks enabled on each text selection change
Summary: RepositoryAction checks enabled on each text selection change
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2013-08-27 10:30 EDT by Robin Stocker CLA
Modified: 2013-09-01 18:38 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Stocker CLA 2013-08-27 10:30:59 EDT 
When selecting text in a file, each change of the selection causes RepositoryAction#selectionChanged to be called with an ITextSelection.

selectionChanged in turn updates the enabled state by calling isEnabled on the handler. isEnabled may involve reading refs or repository config.

The above is multiplied by the number of actions, so it should be avoided. Fix upcoming.
Comment 1 Robin Stocker CLA 2013-08-27 10:38:02 EDT 
Proposed fix: https://git.eclipse.org/r/15896
Comment 2 Matthias Sohn CLA 2013-09-01 18:38:24 EDT 
merged as 374318a5590575c136dfe11273e391ea923d4795