Bug 415133 - "Fetch from Gerrit..." doesn't use configured key binding for content assist but hardcoded "Ctrl+Space"
Summary: "Fetch from Gerrit..." doesn't use configured key binding for content assist ...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 3.0.2   Edit
Assignee: Matthias Sohn CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-15 05:04 EDT by Matthias Sohn CLA
Modified: 2013-08-26 02:18 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Sohn CLA 2013-08-15 05:04:24 EDT
If a user changed the key binding for content assist, the content assist for the refspec in FetchGerritChangePage.addRefContentProposalToText(final Text textField) doesn't respect this configuration. But it should.
Comment 1 Matthias Sohn CLA 2013-08-15 18:38:39 EDT
pushed fix for review
https://git.eclipse.org/r/#/c/15520/
Comment 2 Robin Stocker CLA 2013-08-23 16:38:40 EDT
Merged: https://git.eclipse.org/c/egit/egit.git/commit/?h=stable-3.0&id=fdc286a3ccf49037c55919f24c87daae4b516392

@Matthias: The 3.0.2 target milestone does not yet exist, could you please create it?
Comment 3 Matthias Sohn CLA 2013-08-26 02:18:24 EDT
will be shipped with 3.0.2