Bug 414802 - improved tolerant parsing of function calls
Summary: improved tolerant parsing of function calls
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.0 M2   Edit
Assignee: Manu Sridharan CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2013-08-09 19:43 EDT by Manu Sridharan CLA
Modified: 2013-09-20 15:32 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manu Sridharan CLA 2013-08-09 19:43:15 EDT 
I have a patch to improve tolerant parsing of function calls on a GitHub fork:

https://github.com/msridhar/orion.client/tree/call-tolerant-parsing

Specifically, we can now handle cases like:

function f(s) { ... }

f(JSON.str$$

With the change, the content assist can now suggest 'stringify', whereas before we couldn't suggest anything sensible.  Here's the commit:

https://github.com/msridhar/orion.client/commit/3d5eb19e3e3a9ca4f7ce12c0fa74b6b0f13484a6
Comment 1 Mark Macdonald CLA 2013-08-27 16:51:25 EDT 
Seems like a good improvement; merged to master. Thanks Manu.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e6e267d