Bug 413672 - Update PDE build BREE to 1.6
Summary: Update PDE build BREE to 1.6
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 395421
  Show dependency tree
 
Reported: 2013-07-24 14:22 EDT by Michael Rennie CLA
Modified: 2013-08-07 11:21 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2013-07-24 14:22:46 EDT
Since PDE build extends FileSet from Apache Ant, the update to Ant 1.9.x causes PDE build to no longer compile - as FileSet now has generics in it.

We could simply up the BREE now to get a test build running and fix the type warnings later for M1.
Comment 1 Curtis Windatt CLA 2013-07-24 14:52:48 EDT
http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=050c7ba46d3c1ccbfae57060e3d199802530b40a
Pushed the BREE update to allow the build to complete with Ant 1.9.2 (Bug 395421).

I will work on reducing the compiler warnings and moving the test bundle up as well.
Comment 2 David Williams CLA 2013-07-24 16:55:09 EDT
While I'll "soapbox" once more and say 1.5 would have been adequate, I'll also say that a test build with this change did complete fine. 

I'm not sure the test bundle needs to be changed ... as long as it compiles, it should still run! 

Guess we'll see in the 'nightly'? 

Thanks!
Comment 3 Curtis Windatt CLA 2013-07-25 17:35:47 EDT
http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=2486c47b8fbd00329e784e3efc5b13baad117c51
http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=7922cc8caaca225d1ee2a369123d687427d7c643
http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=f498ef7b934ec0f7d754101f81d4c45d3b35409d
Fixed in master, all raw types warnings removed, annotations added.  All tests pass locally.

If Ant Core reduces its BREE to 1.5, PDE Build will do the same.

I didn't update the test bundle, there are other priorities than working on updating its code.

In a separate commit I will update the ant core dependency to use 3.3.0 as the move to 1.9.2 changes some of the ant API we use (Bug 395421).