Bug 412546 - [patch] PDE build customization target: post.archive
Summary: [patch] PDE build customization target: post.archive
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 4.2.2   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-08 14:29 EDT by Amir Sagie CLA
Modified: 2018-12-03 09:13 EST (History)
1 user (show)

See Also:

Attachments
patch-1of3-org.eclipse.pde.internal.build.AssembleConfigScriptGenerator (741 bytes, patch)
2013-07-08 14:31 EDT, Amir Sagie CLA 		no flags Details | Diff
patch-2of3-org.eclipse.pde.internal.build.IXMLConstants (908 bytes, patch)
2013-07-08 14:31 EDT, Amir Sagie CLA 		no flags Details | Diff
patch-3of3-templates_headless-build_customAssembly.xml (1.04 KB, patch)
2013-07-08 14:31 EDT, Amir Sagie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amir Sagie CLA 2013-07-08 14:29:49 EDT 
PDE build should provide a post.archive customization target hook:
	- this will enable manipulation of generated archives, eg adding per-archive extensions with additional resources
	- provide a useful hook through which both the full archive path as well as it's format ( ${archiveFormet} ) would be available

As a side note I might add that having pre/post hooks for each core target in customAssembly.xml would make more sense to me.

Best,
Amir
Comment 1 Amir Sagie CLA 2013-07-08 14:31:00 EDT 
Created attachment 233239 [details]
patch-1of3-org.eclipse.pde.internal.build.AssembleConfigScriptGenerator
Comment 2 Amir Sagie CLA 2013-07-08 14:31:19 EDT 
Created attachment 233240 [details]
patch-2of3-org.eclipse.pde.internal.build.IXMLConstants
Comment 3 Amir Sagie CLA 2013-07-08 14:31:57 EDT 
Created attachment 233241 [details]
patch-3of3-templates_headless-build_customAssembly.xml
Comment 4 Curtis Windatt CLA 2013-07-08 14:41:25 EDT 
I appreciate the contribution, but there are no active committers to review it.  You are just looking for a target where you can hook in some post archive processing?  I will mark it for 4.4 and if it is simple enough I can try to review.

Not sure why you went with three attachments instead of a single patch.  You can also use gerrit.
Comment 5 Amir Sagie CLA 2013-07-09 01:53:11 EDT 
Simple indeed. Patch set provided to ease patch against each respective target file.
Mainly provided to help avoid archive type identification in Ant after the build has concluded.
Comment 6 Curtis Windatt CLA 2014-04-02 13:57:20 EDT 
Removing the milestone, I do not have time to review PDE Build issues and there are no active committers.
Comment 7 Lars Vogel CLA 2018-12-03 09:10:49 EST 
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 8 Lars Vogel CLA 2018-12-03 09:13:11 EST 
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.