Community
Participate
Working Groups
40 failures in Rename* tests. Failed on a N-build [1] and on latest M-Build [2]. [1]http://download.eclipse.org/eclipse/downloads/drops4/N20130706-1500/testresults/html/org.eclipse.jdt.debug.tests_win32.win32.x86_7.0.html [2] http://download.eclipse.org/eclipse/downloads/drops4/M20130703-0800/testresults/html/org.eclipse.jdt.debug.tests_linux.gtk.x86_6.0.html
Pushed a fix to master: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=104dcc4aaf75b837bffad74d4e782e32b821f6e8 Pushed fix to 4_3_maintenance: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?h=R4_3_maintenance&id=6d7649ec79e1559061e11f6bdd7f3ee8afa77c7b The fix will throw our TestAgainException to retry the test if there is a resource exception during the refactoring - which will work even in a partially modified state because the tests reset the workspace before each run.
This did not do the trick, see http://download.eclipse.org/eclipse/downloads/drops4/I20130709-0800/testresults/html/org.eclipse.jdt.debug.tests_win32.win32.x86_7.0.html
(In reply to comment #2) > This did not do the trick, see > http://download.eclipse.org/eclipse/downloads/drops4/I20130709-0800/ > testresults/html/org.eclipse.jdt.debug.tests_win32.win32.x86_7.0.html Dang, oh well, I guess I will try also trapping CoreExceptions as well: Caused by: org.eclipse.core.runtime.CoreException: The file is not synchronized with the local file system. Also found that the debug test workspace has ResourcesPlugin.PREF_AUTO_REFRESH and ResourcesPlugin.PREF_LIGHTWEIGHT_AUTO_REFRESH set to false. Added a check to master for CoreException and turned on the external refresh preferences: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=c941e797e533bd2628028ff957c55ddbfe059abe Since these test have never failed locally, I tested doing the following: 1. put a breakpoint in AbstractRefactoringDebugTest#performRefactor line 68 2. debug one of the failing tests (for example RenameInnerTypeUnitTests) 3. when the breakpoint suspends open the file being refactored externally and make an edit 4. resume the test I'll leave this open until we get the tests run in the next build. Also pushed changes to Gerrit for 4.3.1 changes: https://git.eclipse.org/r/#/c/14447/
(In reply to comment #3) > Also pushed changes to Gerrit for 4.3.1 changes: > https://git.eclipse.org/r/#/c/14447/ This change has been merged into the repo.
(In reply to comment #4) > (In reply to comment #3) > > Also pushed changes to Gerrit for 4.3.1 changes: > > https://git.eclipse.org/r/#/c/14447/ > > This change has been merged into the repo. The test have not failed since the last update. Marking this as fixed.
