Bug 410471 - Pressing Disconnect button of the debug view does not detach the debugger from attached contexts
Summary: Pressing Disconnect button of the debug view does not detach the debugger fro...
Status: NEW
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: 1.1   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-11 09:23 EDT by Jean-Michel Pedrono CLA
Modified: 2014-03-07 12:24 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Michel Pedrono CLA 2013-06-11 09:23:10 EDT
I'm unclear on what the Disconnect button of the debug view should exactly do?

From what I'm seeing, it seems that BPs are uninstalled, suspended contexts are resumed, but the contexts remains attached (The agent context_detach() is not invoked).
Should not it also detach from attached contexts?

Thanks.
Comment 1 Jean-Michel Pedrono CLA 2013-06-27 03:37:15 EDT
Hello,

No update on this Bug: I just would like a clarification on what Disconnect is supposed to do: Should it detach the debugger from the attached contexts?

Thanks for the clarification.
Regards.
Comment 2 Martin Oberhuber CLA 2013-06-27 07:47:58 EDT
As a user, I care about the effects of the debugger on my target system:

- Are there still any breakpoints ?
- Does my program or system run any slower ?
- Does the debug agent hog any memory on my target ?

What are the effects on my target after a "disconnect" operation ? What is the effect of "being attached" ?

If it's not noticeable to me as an end user, I don't care about it.
Comment 3 Eugene Tarassov CLA 2013-06-27 15:02:12 EDT
Currently, the agent does not do auto-detach on disconnect. If a client does "attach" then disconnects, the debuggee remains attached. The client can do "detach" next time it connects.

Auto-detach seems a good thing to have. However, it can be a problem when multiple clients access same target. I’m not sure what is the best way to handle this.
Comment 4 Jean-Michel Pedrono CLA 2013-06-28 02:01:25 EDT
> Auto-detach seems a good thing to have. However, it can be a problem when multiple clients access same target. I’m not sure what is the best way to handle this.

I guess we can determine how many clients are connected?
If yes, then what about auto-detaching on disconnect when only one client is connected?