Bug 408903 - update disassembly service to be able to run it from TCF server
Summary: update disassembly service to be able to run it from TCF server
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.2   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-23 17:29 EDT by jerome guiban CLA
Modified: 2013-06-05 05:35 EDT (History)
1 user (show)

See Also:

Attachments
suggested patch (13.54 KB, patch)
2013-05-23 17:29 EDT, jerome guiban CLA 		no flags Details | Diff
2nd suggested patch (1st patch does not build on windows host) (14.51 KB, patch)
2013-05-24 09:25 EDT, jerome guiban CLA 		eugene: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jerome guiban CLA 2013-05-23 17:29:28 EDT 
Created attachment 231424 [details]
suggested patch

If a TCF agent does not support the Disassembly service for any reason, this service can be handled by the a TCF server. 

To support Disassembly service from a TCF server, the service must be updated. The attached patch is a suggested update to get Disassembly service supported from TCF server. 

changes description:
 - use cache_enter/cache-exit mechanism for Disassembly service commands.
 - define disassembler list for any context (CONTEXT_GROUP_CPU is not supported by context-proxy)
 - update context-proxy to add “context_get_isa” API and handle “isa” into context cache.
Comment 1 jerome guiban CLA 2013-05-24 09:25:02 EDT 
Created attachment 231464 [details]
2nd suggested patch (1st patch does not build on windows host)

The first attached patch (disassembly.patch) does not buid on Windows host. This second patch fixes this issue.
Comment 2 Eugene Tarassov CLA 2013-05-29 19:36:54 EDT 
I have committed the path after making some changes to resolve few issues.
Thanks!
Comment 3 jerome guiban CLA 2013-05-30 10:48:48 EDT 
Thanks Eugene.

Jérôme.
Comment 4 Martin Oberhuber CLA 2013-06-05 05:35:01 EDT 
This change didn't make 1.1

Should the Component be "Agent" instead of "Core" since it's on the C side ?