Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #366810 +++ Build ID: Eclipse SDK 4.3 RC 1 1. Launch Eclipse SDK, on Welcome page click Samples / SWT and install 2. New > Other > Code Samples > SWT Examples, Finish --> The "org.eclipse.swt.examples" project shows a warning Problems view shows: Description Resource Path Location Type Source folders should not be added to the src.includes list because they are included by default in source builds. build.properties /org.eclipse.swt.examples line 19 Plug-in Problem See also bug 408751 .
This has been fixed a while ago (download the samples from the download page), but the PDE download site has not been updated.
*** Bug 408751 has been marked as a duplicate of this bug. ***
The problem is that we no longer have the code that generated the samples feature. We have the sdk examples feature, but it is packaged differently (though it has similar content). The samples feature contains a single plug-in that contains specifically named zips for the individual sample content. Possible solutions: 1) Try to manually modify an existing sample plug-in/feature with the new SWT sample code. This breaks the versioning scheme and might cause problems with the p2 metadata. 2) Try to recreate the steps to generate the sample plug-in. Will probably involve some manual steps. 3) Try using the sdk examples feature. This is available from the repositories so it would remove PDE from storing the samples on the webiste. However, this could be an enormous chunk of work and could require changes to the welcome API.
(In reply to comment #3) > The problem is that we no longer have the code that generated the samples > feature. We have the sdk examples feature, but it is packaged differently > (though it has similar content). > > The samples feature contains a single plug-in that contains specifically > named zips for the individual sample content. Possible solutions: > > 1) Try to manually modify an existing sample plug-in/feature with the new > SWT sample code. This breaks the versioning scheme and might cause problems > with the p2 metadata. > 2) Try to recreate the steps to generate the sample plug-in. Will probably > involve some manual steps. > 3) Try using the sdk examples feature. This is available from the > repositories so it would remove PDE from storing the samples on the webiste. > However, this could be an enormous chunk of work and could require changes > to the welcome API. Manually create it is the only feasible approach at this time. I would not care about p2. Those who use the sample via p2 will download the sample repo from the downloads page and not via Welcome.
(In reply to comment #4) > Manually create it is the only feasible approach at this time. I would not > care about p2. Those who use the sample via p2 will download the sample repo > from the downloads page and not via Welcome. The welcome page uses p2 to install the samples feature so getting the p2 metadata correct is a requirement.
I attempted to update the content manually and it appears the metadata generated from the site.xml is correct, as I can install the new version from Help > Install New Software. However, the PDE samples action doesn't find the newest version when querying. This could be some caching, or a problem with searching for the feature IU.
(In reply to comment #6) > I attempted to update the content manually and it appears the metadata > generated from the site.xml is correct, as I can install the new version > from Help > Install New Software. However, the PDE samples action doesn't > find the newest version when querying. This could be some caching, or a > problem with searching for the feature IU. The only scenario where this will be used is via Welcome. Not via Install New Software.
Confirmed that this is a caching problem on my machine by testing on Mike's machine. The new version was installed correctly. However, I now see the content is incorrect. The content I used came from the binary output of the examples download. As we want the samples to create a project with useful content I will have to redo the feature with content from the git repository.
The content of the samples now matches what is in the git repository of the SWT examples plug-ins. There are still warnings in a new workspace. If they are a problem, the SWT team should fix them in their repo and I will remake the sample content again. Description Resource Path Location Type Build path specifies execution environment J2SE-1.4. There are no JREs installed in the workspace that are strictly compatible with this environment. org.eclipse.swt.examples Build path JRE System Library Problem No required execution environment has been set MANIFEST.MF /org.eclipse.swt.examples.paint/META-INF line 1 Plug-in Problem No required execution environment has been set MANIFEST.MF /org.eclipse.swt.examples.controls/META-INF line 1 Plug-in Problem No required execution environment has been set MANIFEST.MF /org.eclipse.swt.examples.layouts/META-INF line 1 Plug-in Problem No required execution environment has been set MANIFEST.MF /org.eclipse.swt.examples.launcher/META-INF line 1 Plug-in Problem
(In reply to comment #9) > The content of the samples now matches what is in the git repository of the > SWT examples plug-ins. Verified in I20130528-2000. > There are still warnings in a new workspace. If they are a problem, the SWT > team should fix them in their repo and I will remake the sample content > again. > > Description Resource Path Location Type > Build path specifies execution environment J2SE-1.4. There are no JREs > installed in the workspace that are strictly compatible with this > environment. org.eclipse.swt.examples Build path JRE > System Library Problem This is fine. Just install the corresponding VM. I would not want to change the JRE of the samples this late. > No required execution environment has been set MANIFEST.MF > /org.eclipse.swt.examples.paint/META-INF line 1 Plug-in Problem > No required execution environment has been set MANIFEST.MF > /org.eclipse.swt.examples.controls/META-INF line 1 Plug-in Problem > No required execution environment has been set MANIFEST.MF > /org.eclipse.swt.examples.layouts/META-INF line 1 Plug-in Problem > No required execution environment has been set MANIFEST.MF > /org.eclipse.swt.examples.launcher/META-INF line 1 Plug-in Problem Filed bug 409361 and added a patch. I also updated the samples JAR on the PDE web site.
