Bug 408725 - [release] modeling.gmp.graphiti 0.10.0
Summary: [release] modeling.gmp.graphiti 0.10.0
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Proposals and Reviews (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eclipse Management Organization CLA
QA Contact:
URL: https://projects.eclipse.org/projects...
Whiteboard:
Keywords: Documentation
Depends on:
Blocks: 429163
  Show dependency tree
 
Reported: 2013-05-22 12:39 EDT by Wayne Beaton CLA
Modified: 2014-05-22 16:42 EDT (History)
7 users (show)

See Also:
wayne.beaton: pmc_approved+


Attachments
Approved IP Log (22.19 KB, text/html)
2013-05-27 13:21 EDT, Wayne Beaton CLA
no flags Details
Approved IP Log (17.53 KB, text/html)
2013-05-28 09:50 EDT, Wayne Beaton CLA
no flags Details
Review documentation (147.34 KB, application/octet-stream)
2013-06-06 11:59 EDT, Wayne Beaton CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne Beaton CLA 2013-05-22 12:39:05 EDT
We'll use this bug to track Graphiti's 0.10 release for Kepler.

IP Log has been submitted and forwarded to the IP Team for their review.

Note that per Bug 393682, the Modeling project has been restructured and mid-level "container" projects (e.g. modeling.emf, modeling.emft, etc.) have been marked for termination. This project will have to be moved into the top level project. In all likelihood, very little about the project will have to change. We need to enumerate and effect those changes before this review can be declared successful.

I recommend that we move modeling.gmp.graphiti to modeling.graphiti

I believe that the changes will be minimal. The website and downloads are already in the root, so no change is required there.

I recommend that we move the Graphiti bugs out of the GMP product and into a new Graphiti product (with its own components).

Have I missed anything?
Comment 1 Michael Wenz CLA 2013-05-23 02:49:40 EDT
(In reply to comment #0)
> I recommend that we move modeling.gmp.graphiti to
> modeling.graphiti

> I
> recommend that we move the Graphiti bugs out of the GMP product and into a
> new Graphiti product (with its own components).

+1 from my side

> Have I missed anything?

Our Git repo still has gmp in the name (org.eclipse.gmp.graphiti.git), but I guess that could be neglected.
Comment 2 Wayne Beaton CLA 2013-05-23 15:52:07 EDT
(In reply to comment #1)
> Our Git repo still has gmp in the name (org.eclipse.gmp.graphiti.git), but I
> guess that could be neglected.

It's also in the Git directory structure [1] and Gerrit project [2]

This is your call. I don't think this matters in the short term. In the long term, it might start to get weird. You decide when/if you want to change it.

[1] /gitroot/gmp/org.eclipse.gmp.graphiti.git/
[2] https://git.eclipse.org/r/p/gmp/org.eclipse.gmp.graphiti
Comment 3 Wayne Beaton CLA 2013-05-23 15:53:06 EDT
(In reply to comment #2)
> This is your call. I don't think this matters in the short term. In the long
> term, it might start to get weird. You decide when/if you want to change it.

By "weird", I mean that the name is inconsistent with the usual pattern which may make it harder for some folks to find.
Comment 4 Michael Wenz CLA 2013-05-24 03:02:35 EDT
(In reply to comment #2)
> It's
> also in the Git directory structure [1] and Gerrit project [2]

> This is your
> call. I don't think this matters in the short term. In the long term, it
> might start to get weird. You decide when/if you want to change it.

Maybe I'm too used to it, but I think it's not weird enough to change that. Let's stick to the names.
Comment 5 Wayne Beaton CLA 2013-05-27 13:21:13 EDT
Created attachment 231570 [details]
Approved IP Log
Comment 6 Michael Wenz CLA 2013-05-28 02:04:08 EDT
(In reply to comment #5)
> Created attachment 231570 [details]
> Approved IP Log

It seems there is a slight mix-up here. The attached IP log is for modeling.mdt.ocl
Comment 7 Wayne Beaton CLA 2013-05-28 09:50:27 EDT
Created attachment 231622 [details]
Approved IP Log

I'm not sure what happened. But this should be the right one. Thanks for noticing.
Comment 8 Wayne Beaton CLA 2013-06-06 11:59:22 EDT
Created attachment 232052 [details]
Review documentation
Comment 9 Wayne Beaton CLA 2013-06-06 12:01:04 EDT
PMC Approval: http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg02827.html
Comment 10 Wayne Beaton CLA 2013-06-06 12:07:23 EDT
The Graphiti project logo contains a vendor logo. Project and their logos must be vendor neutral. Please remove the vendor logo from the project logo.

https://projects.eclipse.org/projects/modeling.gmp.graphiti
Comment 11 Michael Wenz CLA 2013-06-07 03:13:58 EDT
(In reply to comment #10)
> The Graphiti project logo contains a vendor logo. Project and their logos
> must be vendor neutral. Please remove the vendor logo from the project logo.
> 
> https://projects.eclipse.org/projects/modeling.gmp.graphiti

Thanks for pointing out. This was actually the old logo. I replaced it with our new and vendor neutral one.
Comment 12 Wayne Beaton CLA 2013-06-17 12:02:55 EDT
I declare this review successful! Please continue with your release.

Please assemble a list of action items to complete the move of this project. There are a few projects that need to move, so let's wait until we have all/most of them ready to go before we copy the webmaster and ask him to effect the changes all at once.
Comment 13 Michael Wenz CLA 2013-06-25 04:36:33 EDT
Wayne, thanks for the email reminder, this somehow dropped off from my list...

We are already independent in the following:
- Website (www.eclipse.org/graphiti)
- Downloads ist at root (download.eclipse.org/graphiti)
- Forum is directly under modeling (http://www.eclipse.org/forums/index.php/f/187/)
- Developer mailing list (graphiti-dev)

I see the following action items to complete the move of Graphiti:
- Rename the project from modeling.gmp.graphiti to modeling.graphiti
- Move the bugzilla component from modeling.GMP.Graphiti to its own product: modeling.Graphiti
- Hudson jobs should be renamed:
  . normal Hudson: gmp-graphiti-nightly -> modeling-graphiti-nightly
  . normal Hudson: emf-graphiti-maintenance -> modeling-graphiti-maintenance 
  . Sandbox Hudson: graphiti.gerrit -> modeling-graphiti-gerrit
- Other than I have written before, I think we should also correct the Git repo name to get everything cleaned up now. Please rename/move from /gitroot/gmp/org.eclipse.gmp.graphiti.git/ to /gitroot/org.eclipse.graphiti.git/ if that has no bad consequences for the git history etc.

I hope I haven't missed anything, in case I have or there are issues with the above just let me know.

Thanks,
Michael
Comment 14 Wayne Beaton CLA 2013-07-11 15:44:45 EDT
(In reply to comment #13)
> - Other than I have written before, I think we should also correct the Git repo
> name to get everything cleaned up now. Please rename/move from
> /gitroot/gmp/org.eclipse.gmp.graphiti.git/ to /gitroot/org.eclipse.graphiti.git/
> if that has no bad consequences for the git history etc.

The convention is to use the project's short name, i.e.

- Move /gitroot/gmp/org.eclipse.gmp.graphiti.git to /gitroot/graphiti/org.eclipse.graphiti.git

I believe that the only impact will be in the configuration of "remotes" in any clones that are out there. You'll have to make sure that your community/adopters are aware of the change.

We'll also have to add moving the IPZilla category.

Does this work for you?
Comment 15 Michael Wenz CLA 2013-07-12 02:51:45 EDT
(In reply to comment #14)
>The convention is to use the project's short name, i.e.
>- Move /gitroot/gmp/org.eclipse.gmp.graphiti.git to
> /gitroot/graphiti/org.eclipse.graphiti.git

>I believe that the only impact
> will be in the configuration of "remotes" in any clones that are out there.
> You'll have to make sure that your community/adopters are aware of the
> change.

>We'll also have to add moving the IPZilla category.

>Does this work
> for you?

+1
Comment 16 Wayne Beaton CLA 2014-02-26 10:46:16 EST
I think that we dropped the ball here. Let's make this happen.

Webmaster and Sharon, please coordinate with Michael to implement the following changes:

- Move /gitroot/gmp/org.eclipse.gmp.graphiti.git to /gitroot/graphiti/org.eclipse.graphiti.git
- Move the bugzilla component from Modeling/GMP/Graphiti to its own product: Modeling/Graphiti/General
- Hudson jobs should be renamed:
. normal Hudson: gmp-graphiti-nightly -> modeling-graphiti-nightly
. normal Hudson: emf-graphiti-maintenance -> modeling-graphiti-maintenance 
. Sandbox Hudson: graphiti.gerrit -> modeling-graphiti-gerrit
- Rename the project from modeling.gmp.graphiti to modeling.graphiti
- Move CQs from modeling.gmp.graphiti to modeling.graphiti

Michael, did I miss anything?
Comment 17 Sharon Corbett CLA 2014-03-11 15:46:40 EDT
Committer legal paperwork has been verified - there are no barriers.

I'll move the CQs accordingly in IPzilla when the project has been renamed...

Over to Webmaster.

Thanks,
Sharon
Intellectual Property
Comment 18 Eclipse Webmaster CLA 2014-03-11 15:49:53 EDT
Michael, when is a good time for the project from me to make these changes?

-M.
Comment 19 Michael Wenz CLA 2014-03-12 11:01:52 EDT
(In reply to Eclipse Webmaster from comment #18)
> Michael, when is a good time for the project from me to make these changes?
> 
> -M.

We have just delivered our M6 contribution, so from my point of view you could start right away.
Comment 20 Eclipse Webmaster CLA 2014-03-13 14:36:13 EDT
(In reply to Wayne Beaton from comment #16)

> - Move /gitroot/gmp/org.eclipse.gmp.graphiti.git to
> /gitroot/graphiti/org.eclipse.graphiti.git

Done.

> - Move the bugzilla component from Modeling/GMP/Graphiti to its own product:
> Modeling/Graphiti/General

Done, although I used 'Core' as the component name rather than 'General'.

> - Hudson jobs should be renamed:
> . normal Hudson: gmp-graphiti-nightly -> modeling-graphiti-nightly
> . normal Hudson: emf-graphiti-maintenance -> modeling-graphiti-maintenance 
> . Sandbox Hudson: graphiti.gerrit -> modeling-graphiti-gerrit

I can't find these jobs, have they been moved to a HIPP instance?

> - Rename the project from modeling.gmp.graphiti to modeling.graphiti

Done.

> - Move CQs from modeling.gmp.graphiti to modeling.graphiti

I'll leave this for the IP team.

-M.
Comment 21 Michael Wenz CLA 2014-03-14 11:12:27 EDT
(In reply to Eclipse Webmaster from comment #20)
> (In reply to Wayne Beaton from comment #16)
> 
> > - Move /gitroot/gmp/org.eclipse.gmp.graphiti.git to
> > /gitroot/graphiti/org.eclipse.graphiti.git
> 
> Done.
> 
> > - Move the bugzilla component from Modeling/GMP/Graphiti to its own product:
> > Modeling/Graphiti/General
> 
> Done, although I used 'Core' as the component name rather than 'General'.
> 
> > - Hudson jobs should be renamed:
> > . normal Hudson: gmp-graphiti-nightly -> modeling-graphiti-nightly
> > . normal Hudson: emf-graphiti-maintenance -> modeling-graphiti-maintenance 
> > . Sandbox Hudson: graphiti.gerrit -> modeling-graphiti-gerrit
> 
> I can't find these jobs, have they been moved to a HIPP instance?
> 
> > - Rename the project from modeling.gmp.graphiti to modeling.graphiti
> 
> Done.
> 
> > - Move CQs from modeling.gmp.graphiti to modeling.graphiti
> 
> I'll leave this for the IP team.
> 
> -M.

Thanks!

Yes, the Hudson jobs do no longer exists, They have been moved to a HIPP instance. They already have correct new names. Sorry, I forgot to update that here.

The Bugzilla 'Core' component is fine for me. Would it be possible for me to have some administration rights for the 'Graphiti' product in Bugzilla? I would like to be able to do version management (create new version entries and the like).

Michael
Comment 22 Sharon Corbett CLA 2014-03-14 11:43:36 EDT
IPzilla CQs have been moved!
Comment 23 Wayne Beaton CLA 2014-03-14 14:16:15 EDT
I've updated the record in the PMI.

Both of these URLs will take you to Graphiti:

https://projects.eclipse.org/projects/modeling.graphiti
https://projects.eclipse.org/projects/modeling.gmp.graphiti

Are we done?
Comment 24 Michael Wenz CLA 2014-03-17 12:12:48 EDT
(In reply to Wayne Beaton from comment #23)
> I've updated the record in the PMI.
> 
> Both of these URLs will take you to Graphiti:
> 
> https://projects.eclipse.org/projects/modeling.graphiti
> https://projects.eclipse.org/projects/modeling.gmp.graphiti
> 
> Are we done?

I think we are.

One last thing I was asked today on the graphiti-dev list:
What about the GitHub mirror? Will it adapt automatically after the rename?

Michael
Comment 25 Michael Wenz CLA 2014-03-24 10:02:07 EDT
I just noticed that the page https://projects.eclipse.org/projects/modeling.graphiti still lists Graphiti under the "Graphical Modeling Project" (and only there).

Is there still something left to configure?

Michael
Comment 26 Wayne Beaton CLA 2014-03-24 10:05:19 EDT
(In reply to Michael Wenz from comment #25)
> I just noticed that the page
> https://projects.eclipse.org/projects/modeling.graphiti still lists Graphiti
> under the "Graphical Modeling Project" (and only there).

That was an oversight. Thanks for noticing.

> Is there still something left to configure?

There was. I fixed it.

That should be it, right? Can we declare victory?
Comment 27 Michael Wenz CLA 2014-03-25 10:28:22 EDT
(In reply to Wayne Beaton from comment #26)
> That should be it, right? Can we declare victory?

Yes I guess, we can. Looks good from me now.

Thanks,
Michael
Comment 28 Denis Roy CLA 2014-03-25 10:31:35 EDT
> One last thing I was asked today on the graphiti-dev list:
> What about the GitHub mirror? Will it adapt automatically after the rename?

It will not.  In fact, we (the Foundation) are no longer supporting automatic mirrors to GitHub since the process is effectively broken.  You are more than welcome to host your own, though.
Comment 29 Wayne Beaton CLA 2014-03-25 15:00:40 EDT
(In reply to Denis Roy from comment #28)
> > One last thing I was asked today on the graphiti-dev list:
> > What about the GitHub mirror? Will it adapt automatically after the rename?
> 
> It will not.  In fact, we (the Foundation) are no longer supporting
> automatic mirrors to GitHub since the process is effectively broken.  You
> are more than welcome to host your own, though.

Nice catch.

Killing off these mirrors is on my to-do list, but I always get caught up on what to do with mirrors that have been forked.

There are two Graphiti mirrors. Do you consider these "in use" by the project?
Comment 30 Michael Wenz CLA 2014-03-26 11:28:43 EDT
(In reply to Wayne Beaton from comment #29)
> Nice catch.
> 
> Killing off these mirrors is on my to-do list, but I always get caught up on
> what to do with mirrors that have been forked.
> 
> There are two Graphiti mirrors. Do you consider these "in use" by the
> project?

In use would be said to much, but I know that one of the mirrors is used by at least one committer.

From my point of view we don not really need them.
Comment 31 Michael Wenz CLA 2014-03-28 08:30:10 EDT
I just found one more issue after the rename: the folder permissions on our signing folder are no longer correct, the new HIPP Hudson user for Graphiti no longer seems to have access to it. Our build produces this exception when I enable signing:
ERROR: org.eclipse.core.runtime.CoreException: /opt/public/hipp/homes/genie.modeling.graphiti/.eclipse/800847737/configuration/org.eclipse.osgi/bundles/25/1/.cp/org/eclipse/buckminster/jarprocessor/antscript/signing.ant:210: Execute failed: java.io.IOException: Cannot run program "/usr/bin/sign" (in directory "/jobs/genie.modeling.graphiti/graphiti.nightly/workspace/graphiti/org.eclipse.graphiti/features/org.eclipse.graphiti.site"): java.io.IOException: error=13, Permission denied
org.eclipse.core.runtime.CoreException: /opt/public/hipp/homes/genie.modeling.graphiti/.eclipse/800847737/configuration/org.eclipse.osgi/bundles/25/1/.cp/org/eclipse/buckminster/jarprocessor/antscript/signing.ant:210: Execute failed: java.io.IOException: Cannot run program "/usr/bin/sign" (in directory "/jobs/genie.modeling.graphiti/graphiti.nightly/workspace/graphiti/org.eclipse.graphiti/features/org.eclipse.graphiti.site"): java.io.IOException: error=13, Permission denied
	at org.eclipse.buckminster.ant.AntRunner.handleInvocationTargetException(AntRunner.java:167)
	at org.eclipse.buckminster.ant.AntRunner.run(AntRunner.java:322)
	at org.eclipse.buckminster.ant.actor.AntActor.internalPerform(AntActor.java:254)
	at org.eclipse.buckminster.core.actor.AbstractActor.perform(AbstractActor.java:195)
	at org.eclipse.buckminster.core.internal.actor.PerformManager$DirectActionInvocation.execute(PerformManager.java:143)
	at org.eclipse.buckminster.core.internal.actor.PerformManager.internalPerform(PerformManager.java:454)
	at org.eclipse.buckminster.core.internal.actor.PerformManager.perform(PerformManager.java:293)
	at org.eclipse.buckminster.core.internal.actor.PerformManager.perform(PerformManager.java:305)
	at org.eclipse.buckminster.core.commands.Perform.internalRun(Perform.java:108)
	at org.eclipse.buckminster.core.commands.WorkspaceCommand.run(WorkspaceCommand.java:91)
	at org.eclipse.buckminster.cmdline.AbstractCommand.basicRun(AbstractCommand.java:200)
	at org.eclipse.buckminster.cmdline.Headless.run(Headless.java:350)
	at org.eclipse.buckminster.cmdline.Headless.run(Headless.java:145)
	at org.eclipse.buckminster.cmdline.Headless.start(Headless.java:165)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:353)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:180)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:629)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:584)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1438)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1414)
Comment 32 Thanh Ha CLA 2014-03-28 09:50:52 EDT
(In reply to Michael Wenz from comment #31)
> I just found one more issue after the rename: the folder permissions on our
> signing folder are no longer correct, the new HIPP Hudson user for Graphiti
> no longer seems to have access to it. Our build produces this exception when
> I enable signing:

Can you try again?

I restarted your HIPP instance and it seems to be able use the "sign" tool now.
Comment 33 Michael Wenz CLA 2014-03-28 10:11:50 EDT
(In reply to Thanh Ha from comment #32)
> I restarted your HIPP instance and it seems to be able use the "sign" tool
> now.

Thanks, the build runs again. I didn't expect that a restart will solve this issue, otherwise I would have did it myself.

Michael
Comment 34 Thanh Ha CLA 2014-03-28 10:15:59 EDT
(In reply to Michael Wenz from comment #33)
> (In reply to Thanh Ha from comment #32)
> > I restarted your HIPP instance and it seems to be able use the "sign" tool
> > now.
> 
> Thanks, the build runs again. I didn't expect that a restart will solve this
> issue, otherwise I would have did it myself.
> 

I'm not sure why but occasionally when HIPP boots up it forgets how to find the "git" tool. Kicking the instance usually fixes it.
Comment 35 Wayne Beaton CLA 2014-05-22 16:42:19 EDT
I think that we can reasonably declare victory on the release review and the project move.

Please open additional bugs for any outstanding issues.