Bug 408576 - read_sigset function returns an aggregate value that generates build warning/error
Summary: read_sigset function returns an aggregate value that generates build warning/...
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: 1.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.1   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-21 09:34 EDT by Sebastien Douheret CLA
Modified: 2013-06-05 04:40 EDT (History)
0 users

See Also:


Attachments
suggested patch (1.81 KB, patch)
2013-05-21 09:34 EDT, Sebastien Douheret CLA
mober.at+eclipse: iplog-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastien Douheret CLA 2013-05-21 09:34:09 EDT
Created attachment 231254 [details]
suggested patch

Function read_sigset returns directly the SigSet structure.
This generate a build error when agent is compile for example with "CFLAGS=-Wall -Waggregate-return -Werror" :
 make CFLAGS="-Wall -Waggregate-return -Wmissing-prototypes -Werror"
 ...
 cc -Wall -Waggregate-return -Wmissing-prototypes -Werror -g -D_FILE_OFFSET_BITS=64 -Wall -Wmissing-prototypes -I./. -I./system/GNU/Linux -I./machine/x86_64 -o obj/GNU/Linux/x86_64/Debug/tcf/services/processes.o -c tcf/services/processes.c
tcf/services/processes.c: In function ‘read_sigset’:
tcf/services/processes.c:576:15: error: function returns an aggregate [-Werror=aggregate-return]
tcf/services/processes.c: In function ‘command_set_signal_mask’:
tcf/services/processes.c:601:15: error: function call has aggregate value [-Werror=aggregate-return]
tcf/services/processes.c:603:15: error: function call has aggregate value [-Werror=aggregate-return]
cc1: all warnings being treated as errors
make: *** [obj/GNU/Linux/x86_64/Debug/tcf/services/processes.o] Error 1
Comment 1 Eugene Tarassov CLA 2013-05-21 12:32:12 EDT
I have committed the patch.
Thanks!
Comment 2 Martin Oberhuber CLA 2013-05-24 18:43:12 EDT
Comment on attachment 231254 [details]
suggested patch

iplog- since git has the author:

http://git.eclipse.org/c/tcf/org.eclipse.tcf.agent.git/commit/?id=2c88e7624d369831771169cd9ccaa351134ccbbe