Bug 408261 - Wrench has role="settings" and there's no such role
Summary: Wrench has role="settings" and there's no such role
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.0 M2   Edit
Assignee: Gabriel Luong CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2013-05-16 11:50 EDT by Carolyn MacLeod CLA
Modified: 2013-05-23 16:07 EDT (History)
2 users (show)

See Also:
libingw: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2013-05-16 11:50:48 EDT 
In file org.eclipse.orion.client.ui/web/orion/banner/toolbar.html

<button class="layoutRight core-sprite-wrench" id="settingsAction" role="settings" aria-live="off" style="visibility:hidden;"></div>

Now that this is a button instead of a div, it doesn't need an explicit role because the default role for <button> is "button". (there's no such role as "settings" anyhow, so the bogus role should just be deleted).
Comment 1 Gabriel Luong CLA 2013-05-16 15:51:39 EDT 
Removed role="settings"
https://github.com/gabrielluong/orion.client/commit/a8dfced0e223ca3b89dc6d4ba76aacd867377a8c

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL
Comment 2 Gabriel Luong CLA 2013-05-23 15:38:59 EDT 
https://orion.eclipse.org/git/reviewRequest.html#git@github.com:gabrielluong/orion.client.git_a8dfced0e223ca3b89dc6d4ba76aacd867377a8c

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL