Comment 1 Konstantin Komissarchik 2013-05-15 14:59:20 EDT

Created attachment 231027 [details]
Schemas (b89)

A zip of schemas from b89 as submitted to the related CQ.

https://dev.eclipse.org/ipzilla/show_bug.cgi?id=7046

Comment 2 Konstantin Komissarchik 2013-05-15 15:02:05 EDT

I will attach a patch for source editing along with a detailed rundown of changes later today.

Comment 3 Konstantin Komissarchik 2013-05-16 11:51:55 EDT

Created attachment 231095 [details]
Schemas (b89)

Now includes beans_1_1.xsd, which is located in modules/weld-osgi-bundle.jar within GF 4 install.

Comment 4 Konstantin Komissarchik 2013-05-16 11:59:32 EDT

Created attachment 231099 [details]
Patch for Source Editing v1

Comment 5 Konstantin Komissarchik 2013-05-16 12:21:38 EDT

Delta from what we currently have:

1. Documentation improvements.

2. In beans_1_1.xsd, scan element has new if-class-not-available child element.

3. In ejb-jar_3_2.xsd, interceptorType has new around-construct child element.

4. In javaee_7.xsd, the class-name element within connection-factory-resourceType has been renamed as interface-name.

5. In javaee_7.xsd, jms-connection-factoryType has new interface-name child element.

6. In javaee_7.xsd, jms-destinationType has new interface-name child element.

7. Some type definitions moved around between web-app_3_1.xsd, web-common_3_1.xsd and web-fragment_3_1.xsd. It isn't immediately clear if other changes are hidden within those movements.

8. In web-facelettaglibrary_2_2.xsd, facelet-taglibType has new short-name child element.

Comment 6 Konstantin Komissarchik 2013-05-16 12:38:02 EDT

Nick,

Could you do take of the patch for Source Editing?

Comment 7 Nick Sandonato 2013-05-16 14:15:04 EDT

* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

These are updates to the Java EE 7 Schemas and are needed to be correct.

* Is there a work-around? If so, why do you believe the work-around is insufficient?

No

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?

(Konstantin might be able to speak more to the testing)

* Give a brief technical overview. Who has reviewed this fix?

Documentation and markup corrections to the XML schemas.

* What is the risk associated with this fix?

Little as it's corrections to new schemas.

Comment 8 Nick Sandonato 2013-05-16 14:18:05 EDT

Thanks for the approval. I've pushed the changes to master and released them.

Comment 9 Konstantin Komissarchik 2013-05-16 14:19:28 EDT

Thanks, Nick.

Carl and Chuck, do you guys want to re-use this bug for the corresponding model changes or open a separate one?