Bug 40681 - no warnings for some externalized strings
Summary: no warnings for some externalized strings
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.0 M3   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-23 18:09 EDT by Andre Weinand CLA
Modified: 2003-08-28 04:52 EDT (History)
0 users

See Also:

Attachments
Patch for this bug (716 bytes, text/plain)
2003-08-20 14:32 EDT, Olivier Thomann CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andre Weinand CLA 2003-07-23 18:09:53 EDT 
M2
- Enable warnings for non-externalized strings
- create this Java class:
public class Test {
	public void test()  {
		"foo".equals("bar");
		//;
	}
}
Observe: there are no NLS warnings for the two strings
- uncomment the semicolon
Observe: now there are two warnings
Comment 1 Olivier Thomann CLA 2003-08-20 14:30:05 EDT 
David, I changed this method protected void checkNonNLSAfterBodyEnd(int) by
replacing < with <= and the problem is fixed.
All tests passed.
You might want to add regression tests.
I will attach the patch file that you need to apply directly on the Parser class.
Comment 2 Olivier Thomann CLA 2003-08-20 14:32:49 EDT 
Created attachment 5805 [details]
Patch for this bug

Apply this patch by selecting the Parser class and run the "Team>Apply
patch..." tool.
Comment 3 David Audel CLA 2003-08-21 06:14:26 EDT 
Patch released and regression test added (ParserTest#test012 and 
ParserTest#test013).

Fixed.
Comment 4 David Audel CLA 2003-08-28 04:52:17 EDT 
Verified.