Bug 405273 - UI does not detect invalid models
Summary: UI does not detect invalid models
Status: RESOLVED FIXED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: UI (show other bugs)
Version: 2.1.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: Luna M3   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2013-04-09 08:39 EDT by William Piers CLA
Modified: 2013-10-21 04:51 EDT (History)
3 users (show)

See Also:

Attachments
the left model (577 bytes, application/octet-stream)
2013-04-09 08:39 EDT, William Piers CLA 		no flags Details
the right model (597 bytes, application/octet-stream)
2013-04-09 08:39 EDT, William Piers CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description William Piers CLA 2013-04-09 08:39:13 EDT 
Created attachment 229498 [details]
the left model

The two models attached are dynamic instances of the Nodes test metamodel.
As the .ecore file is not aside them they can't be opened.
But when comparing each other with EMF compare, it simply detects "no differences". It should detect that the models are invalid instead.
Comment 1 William Piers CLA 2013-04-09 08:39:36 EDT 
Created attachment 229499 [details]
the right model
Comment 2 Laurent Goubet CLA 2013-07-22 05:39:11 EDT 
It seems like this would only require us to display an error message in the structure pane, allowing users to know that something isn't right with the "model" comparison, and that he should instead switch to "textual".
Comment 3 Axel RICHARD CLA 2013-10-09 06:09:43 EDT 
Proposal has been committed: https://git.eclipse.org/r/#/c/17201/

A message is logged, a pop-up is display with the error and the editor is closed.
Comment 4 Mikaël Barbero CLA 2013-10-21 04:51:18 EDT 
Fixed in 792e66bc29b83d8e2510dfd5c54ccde91892020f