Bug 404113 - Disabling JPA facet causes Team disconnect
Summary: Disabling JPA facet causes Team disconnect
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Paul Fullbright CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatbug
Depends on:
Blocks:
 
Reported: 2013-03-22 04:54 EDT by Jesper Skov CLA
Modified: 2013-04-02 02:04 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesper Skov CLA 2013-03-22 04:54:55 EDT
We have started seeing a nasty problem in Kepler (seen in M4+, but is possibly older).

If we disable the JPA facet on an EJB project, the project gets disconnected from the Team integration (in our case, Subversive).

There are no warnings or errors in the logs that coincide with this problem.


How to reproduce (I just did this with Kepler M6):
* create a new EJB project, enable JPA facet.
* Team->Share it to a SVN repository (work with a local file repository)
* See that the project is now connected and has an associated revision.
* Enter Project properties, Project Facets pane. Disable the JPA facet. Click OK.
* See that the project is now disconnected (Team menu is different, close-open project to see associated revision get removed).
Comment 1 Neil Hauge CLA 2013-03-22 10:16:20 EDT
Thanks for the report.  We will look into this ASAP.
Comment 2 Paul Fullbright CLA 2013-03-25 14:50:59 EDT
I found the problem, and it does reach back a few milestones, but no further than that.

Checking in a fix forthwith.
Comment 3 Neil Hauge CLA 2013-03-25 15:00:30 EDT
Not sure if there will be "greatbug" awards in the future, but if so, this would qualify as a candidate.  Thanks for reporting Jesper.
Comment 4 Paul Fullbright CLA 2013-03-26 09:26:08 EDT
Committed for M7.

Here is the commit:  
http://git.eclipse.org/c/dali/webtools.dali.git/commit/?id=8804a1364ee1cd45286d76a8593bc3c13acad5fb
Comment 5 Jesper Skov CLA 2013-04-02 02:04:08 EDT
(In reply to comment #3)
> Not sure if there will be "greatbug" awards in the future, but if so, this
> would qualify as a candidate.  Thanks for reporting Jesper.

My pleasure.

I don't have time to actively contribute to Eclipse, but I'll try riding us close to the edge and report whatever problems we find. Glad to help.

Thanks for the fix, Paul!