Bug 40383 - Search - should only special treat unsaved working copies
Summary: Search - should only special treat unsaved working copies
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.0 M4   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-17 11:15 EDT by Philipe Mulet CLA
Modified: 2003-10-14 11:04 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2003-07-17 11:15:15 EDT 
Build 20030716

Instead of manually resolving all owned working copies, it could only throw 
these which have unsaved changes. The saved one have been indexed already.

Handles should still be mapped to the owned one (if any).
Comment 1 Philipe Mulet CLA 2003-07-17 11:17:33 EDT 
Actually, it may be slightly more difficult than that. If the underlying 
resource is changed again, then it will be further reindexed, and the working 
copy will still reflect the old state. The index state cannot be trusted then.

Unless we are smart enough to notice that a working copy is in sync with the 
underlying resource, we shouldn't change.

Deferring (for now)
Comment 2 Philipe Mulet CLA 2003-07-17 11:20:32 EDT 
Reopening, #isBasedOn should address the consistency issue.
Comment 3 Jerome Lanneluc CLA 2003-09-01 11:03:38 EDT 
Changed SearchEngine to remove from the list of working copies to consider the 
ones that are primary, that don't have unsaved changes, and that are based on 
the underlying resource. See SearchEngine.getWorkingCopies().
Comment 4 David Audel CLA 2003-10-14 11:04:26 EDT 
Verified.