Bug 4036 - Suggestions for Externalize Strings tool (1GGRBYA)
Summary: Suggestions for Externalize Strings tool (1GGRBYA)
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows 2000
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Adam Kiezun CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 23:04 EDT by Nick Edgar CLA
Modified: 2002-01-25 09:08 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2001-10-10 23:04:59 EDT
I've just been trying out the Externalize Strings tool, and find it to be GREAT overall.
Here are a few suggestions for improvement.

Find Strings in package dialog:
- Should show total count across all CUs, i.e. to quickly show that all
strings have or have not been externalized.

- Should allow double-click to open Externalize Strings wizard on selected CU.
  OK to close dialog to do this, or could keep it open.

- Should open 50% wider.


Externalize Strings wizard:
1st page:
- String to externalize table should be taller (can use some of the white space at the bottom),
or shrink Context.

2nd page:
- Should remember settings between invocations, especially for "Create resource bundle accessor class".

3rd page:
- If properties file doesn't exist, get warning saying it will be created, even if it need not be created.
- Wizard page also states that this warning will show up in the workspace, which it doesn't.

4th page:
- Since wizard opens on a single CU, should expand CU by default to show individual changes.

NOTES:

NE (07/12/01 12:04:41 PM)
Other suggestions:

The generated Message class is public, but this should not be API.  It should use package visibility instead.

It would be nice if it could figure out from the context that it does not have to NLS the string,
to avoid generating ugly $NON-NLS-1$ tags.
E.g. if it recognizes the pattern Messages.getString("foo"), it should know that "foo" does not need to be externalized.
Another possibility would be to recognize the specified prefix ("MyPrefix.foo").
JDR would like the option to turn off $NON-NLS$ tag generation, or give the user control over how it's tagged (e.g. generate /* do not NLS */).


AK (7/16/2001 5:29:48 PM)
1. added the counter
2. made the dialog wider
3. made the sash form 50/50
4. create res. bundle field setting remembered
5. the property file is not be created if it does not need to be
Comment 1 DJ Houghton CLA 2001-10-24 07:28:31 EDT
PRODUCT VERSION:
initial

Comment 2 Adam Kiezun CLA 2001-11-05 04:49:48 EST
intend to fix also:
> - Should allow double-click to open Externalize Strings wizard on selected CU.
  OK to close dialog to do this, or could keep it open.
> - Wizard page also states that this warning will show up in the workspace, 
which it doesn't.
Comment 3 Adam Kiezun CLA 2001-11-21 05:11:29 EST
fixed the double click 
> 20011120
Comment 4 Adam Kiezun CLA 2001-12-17 12:45:13 EST
made the warning message better
closing pr >= 20011217
Comment 5 Andre Weinand CLA 2002-01-23 04:12:52 EST
20020115, Win2000: The Externalize Strings Wizard Page is too tall. It fills 
the entire height of the screen (at any resolution) and the "next" and "finish" 
buttons are partly hidden by the windows taskbar. Resizing the taskbar 
readjusts the wizard page so that the buttons are visible.
Comment 6 Adam Kiezun CLA 2002-01-25 09:08:06 EST
fixed together with bug#8194