Bug 403149 - Move POM version tool from PDE to Releng Tools
Summary: Move POM version tool from PDE to Releng Tools
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.3 RC1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 402583
Blocks: 402773 408152
  Show dependency tree
 
Reported: 2013-03-13 04:50 EDT by Dani Megert CLA
Modified: 2013-05-24 05:08 EDT (History)
5 users (show)

See Also:
Michael_Rennie: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2013-03-13 04:50:58 EDT 
4.3 M6

PDE should not know about Tycho / pom files.
Comment 1 Dani Megert CLA 2013-03-13 04:51:44 EDT 
We could move that functionality into the releng bundle while bug 387802 and bug 386114 are not fixed.
Comment 2 Curtis Windatt CLA 2013-05-07 17:19:41 EDT 
Dani, do you have further thoughts on this?  I find the tool quite useful and it integrates well into PDE manifest checking.  The only dependency being added here is having the preference page reference POM files.
Comment 3 Dani Megert CLA 2013-05-08 06:17:59 EDT 
(In reply to comment #2)
> Dani, do you have further thoughts on this?  I find the tool quite useful
> and it integrates well into PDE manifest checking.  The only dependency
> being added here is having the preference page reference POM files.

I'd still like to see this removed. It can be moved to another optional bundle if you want. There are already tools/plug-ins that do exactly that, and more (keep the files in sync). PDE should not start to become/add Tycho tooling.
Comment 4 John Arthorne CLA 2013-05-08 14:06:52 EDT 
We talked about this on the PMC call and agreed it should be removed. There are other plugins that provide this kind of functionality that committers can use, and starting on Maven/Tycho specific tooling in PDE is a slippery slope that we should avoid going down.
Comment 5 Curtis Windatt CLA 2013-05-15 13:11:15 EDT 
Created Bug 408152 to cover adding the tool to releng tools.

https://git.eclipse.org/r/12839
This is the combined revert of the four changes put in for Bug 402583 (http://git.eclipse.org/c/pde/eclipse.pde.ui.git/log/?qt=grep&q=402583).  The copyrights were not reverted.

Mike, can you review the change?
Comment 6 Michael Rennie CLA 2013-05-15 15:27:59 EDT 
+1, merged via gerrit
Comment 7 Dani Megert CLA 2013-05-24 05:08:28 EDT 
Verified in I20130522-2000.