Bug 402596 - Add support for MSP430F5259
Summary: Add support for MSP430F5259
Status: CLOSED FIXED
Alias: None
Product: RTSC (ARCHIVED)
Classification: Technology
Component: Platforms (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Scott Gary CLA
QA Contact:
URL:
Whiteboard: target:3.24.07, 3.25.01
Keywords: readme
Depends on:
Blocks:
 
Reported: 2013-03-06 18:01 EST by Scott Gary CLA
Modified: 2013-06-25 15:15 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Gary CLA 2013-03-06 18:01:03 EST 
Build Identifier: 

The device definition and filters in ti/catalog/msp430/MSP430.xs should be updated to support the MSP430F5259 device.

Reproducible: Always

Steps to Reproduce:
N/A
Actual Results:  
N/A

Expected Results:  
N/A
Comment 1 Dave Russo CLA 2013-03-06 22:53:06 EST 
fixed in gep-e74 and gep-f09
Comment 2 Alan DeMars CLA 2013-03-27 20:14:04 EDT 
In both the g and f trees I think this entry:

    else if (this.$private.realDevice.match(/^MSP430F52\d+/)) {
        this.peripherals["interruptController"] = IC.create(
            {name: "interruptController", baseAddr: 0xFF80, numInterrupts: 64}
        );
        Boot.configureDCO = true;
        tableEntry = "MSP430F552x";
    }

might need to be changed to this:

    else if (this.$private.realDevice.match(/^MSP430F52\d+/)) {
        this.peripherals["interruptController"] = IC.create(
            {name: "interruptController", baseAddr: 0xFF80, numInterrupts: 64}
        );
        Boot.configureDCO = true;
        tableEntry = "MSP430F5259";    <---------!!!!!!!
    }
Comment 3 Alan DeMars CLA 2013-03-28 12:10:58 EDT 
Verify Pass

I spoke with Scott Gary regarding my suggested code change. Some existing 430F52xx devices do NOT follow the 430F5259 mold. Therefore, the suggestion should NOT be followed.

Consequently, I am now satisfied with the code changes.