Description Charles Zhang 2003-07-15 10:29:17 EDT

Adding a switch statement in the aspect code causes the weaving process to 
throw java.lang.NullPointer. This error is reproducable on ajc1.1.0, the 
formal release version. ajc1.0, however, works fine. 

To re-produce, use the following java program:

public class Test {
	public String method1(){
		System.out.println("method1");
		return "method1";
	}
        
        public static void  main(String [] args)
	{
		System.out.println(new Test().method1());
	}
}

And the following AspectJ code:

public privileged aspect TestAspect {
	String around(Test t):target(t)&&
	call(public String method1())
	{
		int flag = 1;
		switch(flag)
		{
			case 1: 
		}
		return null;
	}
}

Here is the output I got:
trouble in:
public class Test extends java.lang.Object:
  public void <init>():
                    ALOAD_0     // Test this   (line 13)
                    INVOKESPECIAL java.lang.Object.<init> ()V
    constructor-execution(void Test.<init>())
    |               RETURN
    constructor-execution(void Test.<init>())
  end public void <init>()

  public String method1():
    method-execution(java.lang.String Test.method1())
    | field-get(java.io.PrintStream java.lang.System.out)
    | |             GETSTATIC java.lang.System.out Ljava/io/PrintStream;   
(line 15)
    | field-get(java.io.PrintStream java.lang.System.out)
    |               LDC "method1"
    | method-call(void java.io.PrintStream.println(java.lang.String))
    | |             INVOKEVIRTUAL java.io.PrintStream.println 
(Ljava/lang/String;)V
    | method-call(void java.io.PrintStream.println(java.lang.String))
    |               LDC "method1"   (line 16)
    |               ARETURN
    method-execution(java.lang.String Test.method1())
  end public String method1()

  public static void main(String[]):
    method-execution(void Test.main(java.lang.String[]))
    | field-get(java.io.PrintStream java.lang.System.out)
    | |             GETSTATIC java.lang.System.out Ljava/io/PrintStream;   
(line 23)
    | field-get(java.io.PrintStream java.lang.System.out)
    |               NEW Test
    |               DUP
    | constructor-call(void Test.<init>())
    | |             INVOKESPECIAL Test.<init> ()V
    | constructor-call(void Test.<init>())
    |               ASTORE_1
    | method-call(java.lang.String Test.method1())
    | |             ALOAD_1
    | |             INVOKESTATIC Test1Aspect.aspectOf ()LTest1Aspect;
    | |             ALOAD_1
    | |             ACONST_NULL
    | |             INVOKESTATIC Test.method1_aroundBody1$advice 
(LTest;LTest1Aspect;LTest;Lorg/aspectj/runtime/internal
/AroundClosure;)Ljava/lang/String;
    | method-call(java.lang.String Test.method1())
    | method-call(void java.io.PrintStream.println(java.lang.String))
    | |             INVOKEVIRTUAL java.io.PrintStream.println 
(Ljava/lang/String;)V
    | method-call(void java.io.PrintStream.println(java.lang.String))
    |               RETURN   (line 24)
    method-execution(void Test.main(java.lang.String[]))
  end public static void main(String[])

  static final String method1_aroundBody0(Test):
                    ALOAD_0
                    INVOKEVIRTUAL Test.method1 ()Ljava/lang/String;   (line 23)
                    ARETURN
  end static final String method1_aroundBody0(Test)

  static final String method1_aroundBody1$advice(Test, Test1Aspect, Test, 
org.aspectj.runtime.internal.AroundClosure):
    advice-execution(java.lang.String Test1Aspect.ajc$around$Test1Aspect$e7
(Test, org.aspectj.runtime.internal.AroundClo
sure))
    |               ICONST_1   (line 18)
    |               ISTORE 4
    |               ILOAD 4   (line 19)
    |               TABLESWITCH
    |                 1:        null
    |                 default:  L0
    |           L0: ACONST_NULL   (line 23)
    |               ARETURN
    advice-execution(java.lang.String Test1Aspect.ajc$around$Test1Aspect$e7
(Test, org.aspectj.runtime.internal.AroundClo
sure))
  end static final String method1_aroundBody1$advice(Test, Test1Aspect, Test, 
org.aspectj.runtime.internal.AroundClosure
)
end public class Test
ABORT
Exception thrown from AspectJ 1.1.0

This might be logged as a bug already -- find current bugs at
  http://bugs.eclipse.org/bugs/buglist.cgi?product=AspectJ&component=Compiler

Bugs for exceptions thrown have titles File:line from the top stack,
e.g., "SomeFile.java:243"

If you don't find the exception below in a bug, please add a new bug
at http://bugs.eclipse.org/bugs/enter_bug.cgi?product=AspectJ
To make the bug a priority, please include a test program
that can reproduce this exception.
null
java.lang.NullPointerException
        at org.aspectj.weaver.bcel.LazyMethodGen.remap(LazyMethodGen.java:892)
        at org.aspectj.weaver.bcel.LazyMethodGen.packBody
(LazyMethodGen.java:800)
        at org.aspectj.weaver.bcel.LazyMethodGen.pack(LazyMethodGen.java:706)
        at org.aspectj.weaver.bcel.LazyMethodGen.getMethod
(LazyMethodGen.java:284)
        at org.aspectj.weaver.bcel.LazyClassGen.writeBack
(LazyClassGen.java:164)
        at org.aspectj.weaver.bcel.LazyClassGen.getJavaClass
(LazyClassGen.java:169)
        at org.aspectj.weaver.bcel.BcelWeaver.dump(BcelWeaver.java:417)
        at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:364)
        at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:335)
        at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:272)
        at 
org.aspectj.ajdt.internal.core.builder.AjBuildManager.weaveAndGenerateClassFile
s(AjBuildManager.java:256)
        at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild
(AjBuildManager.java:164)
        at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild
(AjBuildManager.java:78)
        at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:106)
        at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:60)
        at org.aspectj.tools.ajc.Main.run(Main.java:217)
        at org.aspectj.tools.ajc.Main.runMain(Main.java:155)
        at org.aspectj.tools.ajc.Main.main(Main.java:72)


1 fail|abort