Comment 1 Carolyn MacLeod 2013-02-15 15:19:04 EST

What type of element is it? Is it a link element (i.e. <a> tag?)
Or is it a <div> that has been made to look like a link?

If it is a <div> then it will need to have the following attributes:
    role="link" tabindex=0

If it is an <a> then look to see if it somehow has a tabindex=-1 attribute set?

Comment 2 Carolyn MacLeod 2013-02-15 15:51:05 EST

I see that it is an <a> and that adding tabindex=0 makes it traversable.

Since <a> tags are traversable by default, I wonder why we have to explicitly make this <a> traversable.

Comment 3 Ken Walker 2013-03-15 12:20:19 EDT

Sarah, regarding this pull request:

https://github.com/eclipse/orion.client/pull/23/files#r3126387

Could you please add a comment here like this:

e.g., I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL

Comment 4 Sarah Hong 2013-03-23 16:26:04 EDT

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL

Comment 5 Carolyn MacLeod 2013-04-17 00:15:13 EDT

From Sarah> I've removed the aria-live attribute and committed it, so it should be good to go.

Looks good now, Sarah! Thanks!
Ken, the updated pull request can be committed:
https://github.com/eclipse/orion.client/pull/23/files#r3126387

Comment 6 John Arthorne 2015-05-05 15:48:06 EDT

Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html

Comment 7 John Arthorne 2015-05-05 16:01:28 EDT

Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html