Bug 400138 - Can't close a dialog with ESC if focus is not in a field
Summary: Can't close a dialog with ESC if focus is not in a field
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 20.0   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, triaged
Depends on:
Blocks:
 
Reported: 2013-02-06 14:21 EST by Mark Macdonald CLA
Modified: 2019-03-26 15:46 EDT (History)
3 users (show)

See Also:
mamacdon: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2013-02-06 14:21:26 EST 
1. Press Ctrl+Shift+F to open the Find Files dialog
2. Unfocus the search field by clicking the background of the dialog somewhere.
3. Press ESC
4. Expected the dialog to close but it remains open.
Comment 1 Susan McCourt CLA 2013-02-11 13:06:27 EST 
The general problem was that the modal listener that keeps focus from going outside the dialog, was allowing it to stay in the dialog on items without a tabIndex, which would eventually set focus to the body.  Fixed this so that the listener takes focus back from elements in the dialog with no tabIndex.

However OpenResourceDialog was modeless (simply because I first converted it before I had modal support, and figured it didn't need to be modal).  Given it used to be modal, and that this keyboard focus problem is annoying, I made it modal to take advantage of the general fix.

Mark can you review?

Branch is bug400138, commit is http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=bug400138
Comment 2 Susan McCourt CLA 2013-02-11 14:41:56 EST 
thanks, mark.  pushed.
Comment 3 Susan McCourt CLA 2013-02-12 16:20:29 EST 
Reopened.  This caused bug 400592.
I should have been more careful.  There are DOM elements in the directory prompter (explorer) that don't have a tabIndex/take focus but *do* need a chance to get focus so that some other handler can do the right thing.

As a quick fix I backed out the commit from before, I will investigate this further and see if there is a correct fix for RC2 that isn't too dangerous.
Comment 4 Susan McCourt CLA 2013-02-13 12:49:40 EST 
I've tried a few different things but don't feel confident fixing it this late.  Moving to 3.0 M1.
Comment 5 Mike Wilson CLA 2013-05-27 14:41:58 EDT 
I just hit this again in the find/replace panel of the editor. It seems more obviously wrong to me now that we correctly close the status dropdown when you hit ESC.
Comment 6 John Arthorne CLA 2015-05-05 14:49:53 EDT 
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html
Comment 7 Carolyn MacLeod CLA 2017-06-02 16:35:47 EDT 
Still valid.

Also a problem in the 'Clone Repository' or 'Init Repository' dialogs in the Repositories dropdown, and the 'New Remote' or 'New Branch' dialogs in the References dropdown.