Bug 399935 - j2ee_1_4.xsd is incorrectly registered
Summary: j2ee_1_4.xsd is incorrectly registered
Status: VERIFIED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xml (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.4.2   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard: PMC
Keywords: performance
Depends on:
Blocks:
 
Reported: 2013-02-04 17:37 EST by Konstantin Komissarchik CLA
Modified: 2013-02-07 16:57 EST (History)
2 users (show)

See Also:
thatnitind: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
thatnitind: pmc_approved? (naci.dai)
neil.hauge: pmc_approved+
thatnitind: pmc_approved? (kaloyan)
thatnitind: pmc_approved? (cbridgha)

Attachments
Patch v1 (590 bytes, patch)
2013-02-04 17:39 EST, Konstantin Komissarchik CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Komissarchik CLA 2013-02-04 17:37:53 EST 
Only the following registration for j2ee_1_4.xsd is present.

<uri
   name="http://java.sun.com/xml/ns/j2ee/"
   uri="dtdsAndSchemas/j2ee_1_4.xsd" />

While this might be useful in some cases, this xsd will most frequently be referenced by its schema location and that registration is missing.

We need to add this:

<uri
   name="http://java.sun.com/xml/ns/j2ee/j2ee_1_4.xsd"
   uri="dtdsAndSchemas/j2ee_1_4.xsd" />

I am setting severity to major as this problem is causing Eclipse to hang waiting for network timeout while doing many common WTP operations in certain networks environments.
Comment 1 Konstantin Komissarchik CLA 2013-02-04 17:39:45 EST 
Created attachment 226542 [details]
Patch v1
Comment 2 Konstantin Komissarchik CLA 2013-02-04 17:40:07 EST 
Please consider for Juno SR2.
Comment 3 Nitin Dahyabhai CLA 2013-02-04 17:57:12 EST 
Requesting PMC review on behalf of Konstantin.
Comment 4 Nitin Dahyabhai CLA 2013-02-04 17:59:04 EST 
Explain why you believe this is a stop-ship defect.
* Perceived performance

Is there a work-around? If so, why do you believe the work-around is insufficient?
* User could change their files, but we don't like recommending that.

How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?
* No code change to test.  XSD already present in plug-in.

Give a brief technical overview. Who has reviewed this fix?
* Adds an additional URI entry for the schema into the XML Catalog

What is the risk associated with this fix?
* Negligible.
Comment 5 Neil Hauge CLA 2013-02-04 18:53:01 EST 
Benefit/risk ratio seems reasonable.
Comment 6 Nitin Dahyabhai CLA 2013-02-05 02:36:28 EST 
Released to maintenance, pushed to master.
Comment 7 Konstantin Komissarchik CLA 2013-02-07 16:57:00 EST 
Verified in 3.4.2 RC3 and 3.5 M5. Thanks.