Bug 399591 - [compiler] Visibility of overridden method not properly applied
Summary: [compiler] Visibility of overridden method not properly applied
Status: NEW
Alias: None
Product: Xtend
Classification: Tools
Component: Core (show other bugs)
Version: 2.4.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-31 04:17 EST by Sebastian Zarnekow CLA
Modified: 2018-10-08 14:42 EDT (History)
2 users (show)

See Also:


Attachments
Test Case (1.05 KB, application/octet-stream)
2016-08-22 13:54 EDT, Karsten Thoms CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Zarnekow CLA 2013-01-31 04:17:37 EST
I cannot reproduce this reliably but the class TimedBatchTypeResolver is compiled with a public method #createResolver even though it is protected in DefaultBatchTypeResolver
Comment 1 Sven Efftinge CLA 2013-09-12 17:11:25 EDT
Still doesn't work with 2.4.3
Comment 2 Karsten Thoms CLA 2016-08-22 13:54:23 EDT
Created attachment 263707 [details]
Test Case

This test reproduces the issue.

I think the problem is that XtendJvmModelInferrer.transform(XtendFunction, JvmGenericType, boolean) has to set the visibility to the overridden method's visibility, but I did not see if this could be safely computed in the inferrer. If the inferrer is not the right place to set the JvmOperation's visibility, where would it be?
Comment 3 Eclipse Genie CLA 2018-10-08 14:42:11 EDT
GitHub Pull Request 599 created by [miklossy]
https://github.com/eclipse/xtext-xtend/pull/599