Bug 399398 - Support Mylyn links in git history view
Summary: Support Mylyn links in git history view
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 2.2   Edit
Hardware: Other All
: P3 normal (vote)
Target Milestone: 3.1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 338579 (view as bug list)
Depends on:
Blocks: 411809 427811
  Show dependency tree
 
Reported: 2013-01-29 11:00 EST by Alex Blewitt CLA
Modified: 2014-06-03 08:29 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2013-01-29 11:00:48 EST 
If you have a reference to a bug in a Java source file (eg // fixes bug 12345) then this will be hyperlinkable to the issue in Mylyn. 

It would be great to support this in the Git histories view, so if you commit message with "bug 12345" in the text it will be linked as well. 

This code is already implemented in Mylyn so may be a case of booking it up as a link detector if present.
Comment 1 Steve Elsemore CLA 2013-06-21 13:42:39 EDT 
Proposed fix:

https://git.eclipse.org/r/13987

Note that the Mylyn Bugzilla plugin's hyperlink detector currently will detect a hyperlink for "bug 12345", but not for "Bug: 12345".  A separate issue/patch should be provided to address that (enhance the BugzillaConnectorUi regex used for finding bug links).
Comment 2 Steve Elsemore CLA 2013-06-24 10:57:35 EDT 
Feature should also be implemented for staging view and commit dialog.
Comment 3 Steve Elsemore CLA 2013-06-24 16:02:09 EDT 
I don't understand what caused the build failure.  Can someone take a look?  Thanks.

https://git.eclipse.org/r/13987
Comment 4 Matthias Sohn CLA 2013-06-24 19:27:20 EDT 
merged as 0906cde57ce4ae4117151d96a2af82e0dc076593
Comment 5 Robin Stocker CLA 2013-09-27 13:42:16 EDT 
*** Bug 338579 has been marked as a duplicate of this bug. ***
Comment 6 Robin Stocker CLA 2014-02-17 07:56:57 EST 
(In reply to Matthias Sohn from comment #4)
> merged as 0906cde57ce4ae4117151d96a2af82e0dc076593

This seems to have caused bug 427811.
Comment 7 Dani Megert CLA 2014-06-03 08:29:09 EDT 
(In reply to Robin Stocker from comment #6)
> (In reply to Matthias Sohn from comment #4)
> > merged as 0906cde57ce4ae4117151d96a2af82e0dc076593
> 
> This seems to have caused bug 427811.


This also broke spell checking (see bug 428320). The implementation directly accesses the StyledText widget instead of using the source viewer infrastructure.