Bug 399101 - RSE edit actions on local files that map to actually workspace resources should not use temp files
Summary: RSE edit actions on local files that map to actually workspace resources shou...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Xuan Chen CLA
QA Contact: David Dykstal CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-25 10:45 EST by Xuan Chen CLA
Modified: 2013-06-18 10:11 EDT (History)
1 user (show)

See Also:
dmcknigh: review+
dmcknigh: review?

Attachments
Patch for the item (24.23 KB, patch)
2013-01-28 16:40 EST, Xuan Chen CLA 		no flags Details | Diff
Updated patch with additional copy right changes. (26.50 KB, patch)
2013-01-28 16:59 EST, Xuan Chen CLA 		no flags Details | Diff
Updated patch which addresses Dave D's comment and fixes a rename problem (29.09 KB, patch)
2013-01-30 14:52 EST, Xuan Chen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xuan Chen CLA 2013-01-25 10:45:16 EST 
When a file is opened via RSE, the remote file is first transferred into the RemoteSystemTempFiles project before opening in an editor.  
When using RSE to open a file that is in the Local connection, a check should be made to ensure that the file does not exist as an Eclipse workspace file.  If the file is a workspace file, then rather copying the file to the RemoteSystemTempFiles project, the file should be opened directly.  This is to avoid having more than one of the same editor open for a given workspace file and avoiding the conflicts that can result between the synchronized temp file and the actual file.
Comment 1 Xuan Chen CLA 2013-01-28 16:40:02 EST 
Created attachment 226227 [details]
Patch for the item

Patch for this bug.
Comment 2 Xuan Chen CLA 2013-01-28 16:59:02 EST 
Created attachment 226229 [details]
Updated patch with additional copy right changes.

Updated with additional copy right changes.
Comment 3 Xuan Chen CLA 2013-01-28 17:00:06 EST 
Dave M, could you please review the fix?  Thanks.
Comment 4 David McKnight CLA 2013-01-29 11:53:07 EST 
The changes look good to me.  Dave D, since this is a fairly large change can you also do a review?
Comment 5 Xuan Chen CLA 2013-01-30 14:52:06 EST 
Created attachment 226338 [details]
Updated patch which addresses Dave D's comment and fixes a rename problem

I updated the patch with some comment from Dave D (through the phone).
And I also found a problem with rename, and have a fix for it.

Please review it.  Thanks.
Comment 6 David McKnight CLA 2013-01-30 15:36:48 EST 
I looked at the code and tested out the patch and things look good to me.
Comment 7 Xuan Chen CLA 2013-01-30 16:18:12 EST 
Dave M, Dave D,
Thanks for the reviews. 
I've delivered the changes.
Comment 8 David McKnight CLA 2013-06-18 10:11:37 EDT 
This was resolved a while back.