Bug 398154 - [CSS] Removing the existing keybinding at every startup
Summary: [CSS] Removing the existing keybinding at every startup
Status: CLOSED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2013-01-15 03:51 EST by Lars Vogel CLA
Modified: 2015-01-22 09:19 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2013-01-15 03:51:41 EST 
The keybindings were changed for OpenScratchPad and Open CSS Spy and Brian implemented a logic to remove the old keybinding. 

Looks to me that this is called every time at startup of Eclipse. I think it should check the existing shortcut and only remove it if it the old shortcut.

Info
Tue Jan 15 08:55:12 CET 2013
Removing existing binding for org.eclipse.e4.css.OpenSctachpad to M2+M3+F6
eclipse.buildId=N20130112-2000

Info
Tue Jan 15 08:55:12 CET 2013
Removing existing binding for org.eclipse.e4.css.OpenSpy to M2+M3+F5
Comment 1 Nobody - feel free to take it CLA 2014-02-05 06:58:20 EST 
I have a potentially unrelated note. Is the live editor shortcut working for you in latest tools with the latest Luna?
Comment 2 Lars Vogel CLA 2014-02-05 07:08:21 EST 
(In reply to Sopot Cela from comment #1)
> I have a potentially unrelated note. Is the live editor shortcut working for
> you in latest tools with the latest Luna?

I noticed today that the shortcut for Live Model Editor as well as the CSS Spy don't work anymore. I checked in the live model editor that they are added but they don't work. I did not investigate this yet.
Comment 3 Dmitry Spiridenok CLA 2014-04-01 15:18:27 EDT 
Does this problem still exist? When I start another Eclipse application from an existing Eclipse workspace, I do not see these info messages. 
I do see the following messages but they don't look the same to me:
"
!ENTRY org.eclipse.e4.ui.workbench 1 0 2014-04-01 21:15:56.358
!MESSAGE Plugin 'org.eclipse.e4.tools.event.spy': installing ...

!ENTRY org.eclipse.e4.ui.workbench 1 0 2014-04-01 21:15:56.384
!MESSAGE Plugin 'org.eclipse.e4.tools.event.spy': key binding for command 'Open event spy dialog' is M2+M3+F8

!ENTRY org.eclipse.e4.ui.workbench 1 0 2014-04-01 21:15:56.385
!MESSAGE Plugin 'org.eclipse.e4.tools.event.spy': installed
"

If the problem still exists, please specify in more details how it can be reproduced.
Comment 4 Olivier Prouvost CLA 2014-06-13 17:55:56 EDT 
It should be fixed when I will definitively integrate the css spy and css scratch in the common spy e4 window (see bug #428903).
Comment 5 Lars Vogel CLA 2015-01-22 08:46:30 EST 
(In reply to Olivier Prouvost from comment #4)
> It should be fixed when I will definitively integrate the css spy and css
> scratch in the common spy e4 window (see bug #428903).

Olivier, can this be marked as fixed?
Comment 6 Olivier Prouvost CLA 2015-01-22 09:19:14 EST 
Keybindings are now initialized in the org.eclipse.e4.tools.spy.SpyProcessor, by reading the 'org.eclipse.e4.tools.spy.spyPart' extensions.

So we can close this bug