Bug 398149 - [patch] Builder template lacks implementation of clean() method
Summary: [patch] Builder template lacks implementation of clean() method
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.3 M5   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2013-01-15 03:12 EST by maarten meijer CLA
Modified: 2013-01-15 12:56 EST (History)
1 user (show)

See Also:

Attachments
patch to add default implementation of clean() method (788 bytes, patch)
2013-01-15 03:23 EST, maarten meijer CLA 		curtis.windatt.public: iplog+
Details | Diff
mylyn/context/zip (3.31 KB, application/octet-stream)
2013-01-15 03:23 EST, maarten meijer CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description maarten meijer CLA 2013-01-15 03:12:39 EST 
The builder generated from the template lacks an implementation of the clean() method, while http://www.eclipse.org/articles/Article-Builders/builders.html states that all builders should implement clean().
Comment 1 maarten meijer CLA 2013-01-15 03:23:06 EST 
Created attachment 225606 [details]
patch to add default implementation of clean() method
Comment 2 maarten meijer CLA 2013-01-15 03:23:09 EST 
Created attachment 225607 [details]
mylyn/context/zip
Comment 3 maarten meijer CLA 2013-01-15 03:26:56 EST 
Creating patch of only intended changes is not trivial, needs disabling formatting and save actions. 
Does PDE have default settings for IDE for this?
What is recommended API baseline?
Comment 4 maarten meijer CLA 2013-01-15 10:16:16 EST 
Should first be vetted
Comment 5 Curtis Windatt CLA 2013-01-15 12:56:41 EST 
Fixed in master
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=de65c06c8c3c18425173c746727fd48ff01a199d

I removed the @override annotation for consistency.

(In reply to comment #3)
> Creating patch of only intended changes is not trivial, needs disabling
> formatting and save actions. 
> Does PDE have default settings for IDE for this?
> What is recommended API baseline?

The PDE projects should have custom preferences for actions on save, errors/warnings, etc.  If you want to change those settings you can right click on a projects > Properties.

For a baseline you should use a downloaded Eclipse install from the previous release (so 4.2 in this case).

If a patch includes some trivial changes to the files, this isn't a problem.  It's only when there are so many changes the real fix is hard to decipher.