Bug 398122 - Login page: Sign in links should have role="link"
Summary: Login page: Sign in links should have role="link"
Status: RESOLVED WONTFIX
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2013-01-14 14:45 EST by Carolyn MacLeod CLA
Modified: 2015-05-05 14:49 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2013-01-14 14:45:01 EST
Please see the design pattern for keyboard interaction for the button role:
http://www.w3.org/WAI/PF/aria-practices/#button

Note that both Enter and Space should activate a button.

None of the buttons on http://orion.eclipse.org/ can be activated with the space key (they can be activated with the Enter key). This is mostly a problem because the screen reader says "... button. To activate, press space bar."
Comment 1 Carolyn MacLeod CLA 2013-01-14 14:53:00 EST
Actually, this type of "sign in" control is handled inconsistently in the community.

On facebook.com, the Log In button is an <input type="submit"> (which has role="button") and the Sign Up button is a <button> (with type="submit"?).
Both will activate on space bar (and enter).

On google.com, the Sign in button is just a link <a> that looks like a button but does not behave like one (its role is link). It does *not* activate on space (only on enter). Here is the design pattern for link:
http://www.w3.org/WAI/PF/aria-practices/#link

So we need to decide which semantics we prefer, or maybe do a little survey of respected web sites and see if there's any sort of consensus.
Comment 2 Susan McCourt CLA 2013-01-14 14:58:23 EST
(In reply to comment #0)
> None of the buttons on http://orion.eclipse.org/ can be activated with the
> space key (they can be activated with the Enter key). 

I assume you mean none of the buttons on login page.  Most buttons do handle space key (via the command service).
Comment 3 Carolyn MacLeod CLA 2013-01-14 15:26:45 EST
Sorry, yes. I mean just the login page. The 3 sign-in buttons, and the twitter/news buttons do not activate on space.
Comment 4 Carolyn MacLeod CLA 2013-01-25 11:04:11 EST
The point is that if something has role="button", then it should support space.
However, these things could quite easily be links, and then they only need to support Enter.

So I am changing the title of this bug to say that they should have role="link" instead of role="button".

There is also an inconsistency that needs to be investigated: the "Sign in with associated Google account" already has the 'link' context menu (i.e. Open link in new tab/window, Bookmark/Save/Copy link, etc) when you either right-click on it or type Shift+F10 when it has focus. However, "Orion" and "Mozilla Persona" do not have the 'link' context menu - but they should.
Comment 5 Carolyn MacLeod CLA 2013-01-25 11:08:55 EST
By the way, the twitter & news links are fine as-is. The are anchors (<a>...</a>)
so they automatically have role="link", they are activated with Enter, and they have the 'link' context menu. No change there.
Comment 6 John Arthorne CLA 2015-05-05 14:49:32 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html