Bug 397760 - Make the gear menu reusable and accessible
Summary: Make the gear menu reusable and accessible
Status: RESOLVED WONTFIX
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-09 08:39 EST by Anton McConville CLA
Modified: 2015-05-05 16:01 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anton McConville CLA 2013-01-09 08:39:16 EST
From Carolyn:

Just wondering if your new gear menu is accessible. <grin>

Can you tab to the gear button using the keyboard? If not, then please give it tabindex="0".
What key "drops down the menu"? (or do you prefer to think of it as "popping up the dialog"?)
Assuming you want to think of it as a menu button, here's the recommended keystrokes: http://www.w3.org/WAI/PF/aria-practices/#menubutton
(i.e. Enter, Space, and Down arrow all drop down the menu <grin>, and there's some other keyboard interaction to think about, too...).
(If you prefer to think of it as a dialog, then things change a bit... http://www.w3.org/WAI/PF/aria-practices/#dialog_modal)

Did you already give the gear some alt text (i.e. if it's an <img> or some other element that has the "alt" property) or an aria-label (if it's a <div> or whatever else)?
(i.e. maybe it can have aria-label="Editor Settings" or something like that).

Is the gear a <button> or is it a <div> or an <img> or something?
If it isn't already a <button> then it will need role="button".
And you might want role="menu" on the popup div or maybe even role="dialog", depending on how you want to present it.

The gear should have aria-haspopup="true", and the popup div probably needs an aria-hidden="true" that you switch to aria-hidden="false" when you make it visible (and back to "true" when it is hidden again).

This section in the ARIA Authoring Practices gives a nice step-by-step walkthrough of the kinds of things to think about... <g>
http://www.w3.org/WAI/PF/aria-practices/#accessiblewidget
(for example, the bit in point 8 that says if you are using css to show/hide the popup div, then "do this"... it may be useful to you)

Also, the gear menu needs another pass to make it reusable in other contexts.
Comment 1 Carolyn MacLeod CLA 2013-01-09 12:18:33 EST
As per discussion, the best semantic representation for the popup div is role="dialog". (this is because it contains combos and not menu items, and because it will keep the keyboard focus until the user dismisses it with the escape key).
Comment 2 Carolyn MacLeod CLA 2013-01-09 12:23:24 EST
FYI, you might want to follow bug 397767 as there might be some similarities between this and Orion dialogs in general.
Comment 3 John Arthorne CLA 2015-05-05 15:48:34 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html
Comment 4 John Arthorne CLA 2015-05-05 16:01:45 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html